From 1fefa29c34b8177779a237e26984ae973adf23e9 Mon Sep 17 00:00:00 2001 From: Peter Jones Date: Tue, 16 Jun 2015 11:41:32 -0400 Subject: Fix console_print_box*() parameters. When we made lib build with the correct CFLAGS, it inherited -Werror=sign-compare, and I fixed up some parameters on console_print_box() and console_print_box_at() to avoid sign comparison errors. The fixups were *completely wrong*, as some behavior relies on negative values. So this fixes them in a completely different way, by casting appropriately to signed types where we're doing comparisons. Signed-off-by: Peter Jones --- include/console.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'include/console.h') diff --git a/include/console.h b/include/console.h index ecaa73f5..d59e3b4f 100644 --- a/include/console.h +++ b/include/console.h @@ -4,12 +4,12 @@ EFI_STATUS console_get_keystroke(EFI_INPUT_KEY *key); void -console_print_box_at(CHAR16 *str_arr[], unsigned int highlight, - unsigned int start_col, unsigned int start_row, - unsigned int size_cols, unsigned int size_rows, - int offset, unsigned int lines); +console_print_box_at(CHAR16 *str_arr[], int highlight, + int start_col, int start_row, + int size_cols, int size_rows, + int offset, int lines); void -console_print_box(CHAR16 *str_arr[], unsigned int highlight); +console_print_box(CHAR16 *str_arr[], int highlight); int console_yes_no(CHAR16 *str_arr[]); int -- cgit v1.2.3