From d0df9304c7a777557e1925dc9f75406ec00e6179 Mon Sep 17 00:00:00 2001
From: Peter Jones <pjones@redhat.com>
Date: Thu, 9 Dec 2021 17:21:45 -0500
Subject: Minor coverity fixes

- one missing free
- one minor deadcode issue
- two unchecked allocations
- one debug hexdump of a variable we just freed

Signed-off-by: Peter Jones <pjones@redhat.com>
---
 lib/variables.c | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'lib/variables.c')

diff --git a/lib/variables.c b/lib/variables.c
index 3ec05478..8e63aa8f 100644
--- a/lib/variables.c
+++ b/lib/variables.c
@@ -68,6 +68,8 @@ fill_esl_with_one_signature(const uint8_t *data, const uint32_t data_len,
 
 	if (out) {
 		sd = AllocateZeroPool(sig_size);
+		if (!sd)
+			return EFI_OUT_OF_RESOURCES;
 		if (owner)
 			CopyMem(sd, (void *)owner, sizeof(EFI_GUID));
 		CopyMem(sd->SignatureData, (void *)data, data_len);
-- 
cgit v1.2.3