From e136e645d54983d2b5a89610d1565c23538ca1fa Mon Sep 17 00:00:00 2001 From: Peter Jones Date: Tue, 18 Feb 2025 12:55:05 -0500 Subject: mock-variables: fix debugging printf format specifier oopsie This debug printf in our mock variable test code, which isn't normally enabled, has a missing comma at the end of the format specifier. This causes __FILE__ to be part of the format specifier, which then means we've got a missing parameter and also the types don't match up like you'd hope. This causes the most confusing segfaults. Signed-off-by: Peter Jones --- mock-variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mock-variables.c') diff --git a/mock-variables.c b/mock-variables.c index 656670d5..81828560 100644 --- a/mock-variables.c +++ b/mock-variables.c @@ -391,7 +391,7 @@ mock_get_next_variable_name(UINTN *size, CHAR16 *name, EFI_GUID *guid) } #if (defined(SHIM_DEBUG) && SHIM_DEBUG != 0) if (result) { - printf("%s:%d:%s(): found:%d result:%p &result->guid:%p &result->list:%p\n" + printf("%s:%d:%s(): found:%d result:%p &result->guid:%p &result->list:%p\n", __FILE__, __LINE__-1, __func__, found, result, &result->guid, &result->list); printf("%s:%d:%s(): "GUID_FMT"-%s\n", -- cgit v1.2.3