From 2a2ae40523fc9c735771ee3a4acfb866fdf0e586 Mon Sep 17 00:00:00 2001 From: Peter Jones Date: Thu, 11 Mar 2021 17:20:52 -0500 Subject: set_sbat_uefi_variable(): align some decisions that are off-by-one. Fix a couple of small off-by-one errors in the SBAT variable initial setup and validation path. Signed-off-by: Peter Jones --- sbat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'sbat.c') diff --git a/sbat.c b/sbat.c index 0baaa5a3..89c08417 100644 --- a/sbat.c +++ b/sbat.c @@ -324,8 +324,8 @@ set_sbat_uefi_variable(void) if (EFI_ERROR(efi_status)) { dprint(L"SBAT read failed %r\n", efi_status); } else if (check_sbat_var_attributes(attributes) && - sbatsize >= strlen(SBAT_VAR_SIG "1") && - strncmp((const char *)sbat, SBAT_VAR_SIG, + sbatsize >= strlen(SBAT_VAR_SIG "1") && + strncmp((const char *)sbat, SBAT_VAR_SIG, strlen(SBAT_VAR_SIG))) { dprint("SBAT variable is %d bytes, attributes are 0x%08x\n", sbatsize, attributes); @@ -348,7 +348,7 @@ set_sbat_uefi_variable(void) /* set variable */ efi_status = set_variable(SBAT_VAR_NAME, SHIM_LOCK_GUID, SBAT_VAR_ATTRS, - sizeof(SBAT_VAR), SBAT_VAR); + sizeof(SBAT_VAR)-1, SBAT_VAR); if (EFI_ERROR(efi_status)) { dprint(L"SBAT variable writing failed %r\n", efi_status); return efi_status; -- cgit v1.2.3