Routing table base class.

1 files changed, 14 insertions, 64 deletions

diff --git a/node/RoutingTable.hpp b/node/RoutingTable.hpp
index 1750a510..8f6a4642 100644
--- a/node/RoutingTable.hpp
+++ b/node/RoutingTable.hpp
@@ -28,16 +28,11 @@
 #ifndef ZT_ROUTINGTABLE_HPP
 #define ZT_ROUTINGTABLE_HPP
 
-#include <stdint.h>
-#include <string.h>
-#include <stdlib.h>
-
 #include <vector>
 #include <string>
 
 #include "InetAddress.hpp"
 #include "NonCopyable.hpp"
-#include "Utils.hpp"
 
 namespace ZeroTier {
 
@@ -53,90 +48,45 @@ public:
 		Entry() { device[0] = (char)0; }
 
 		InetAddress destination;
-		InetAddress gateway;
+		InetAddress gateway; // port/netmaskBits field not used, should be 0
 		char device[128];
 		int metric;
 
-		inline bool operator==(const Entry &re) const { return ((destination == re.destination)&&(gateway == re.gateway)&&(strcmp(device == re.device) == 0)&&(metric == re.metric)); }
+		std::string toString() const;
+
+		bool operator==(const Entry &re) const;
 		inline bool operator!=(const Entry &re) const { return (!(*this == re)); }
-		inline bool operator<(const Entry &re) const
-		{
-			if (destination < re.destination)
-				return true;
-			if (destination == re.destination) {
-				if (gateway < re.gateway)
-					return true;
-				if (gateway == re.gateway) {
-					int tmp = (int)::strcmp(device,re.device);
-					if (tmp < 0)
-						return true;
-					if (tmp == 0)
-						return (metric < re.metric);
-				}
-			}
-			return false;
-		}
+		bool operator<(const Entry &re) const;
 		inline bool operator>(const Entry &re) const { return (re < *this); }
 		inline bool operator<=(const Entry &re) const { return (!(re < *this)); }
 		inline bool operator>=(const Entry &re) const { return (!(*this < re)); }
 	};
 
-	SystemNetworkStack() {}
-	virtual ~SystemNetworkStack() {}
+	RoutingTable();
+	virtual ~RoutingTable();
 
 	/**
-	 * @return All routing table entries sorted in order of destination address / netmask
+	 * @return Sorted routing table entries
 	 */
-	virtual std::vector<Entry> routingTable() const = 0;
+	virtual std::vector<Entry> get() const = 0;
 
 	/**
 	 * Add or update a routing table entry
 	 *
 	 * @param re Entry to add/update
-	 * @return True if successful
+	 * @return True if change successful (or unchanged)
 	 */
-	virtual bool addUpdateRoute(const Entry &re) = 0;
+	virtual bool set(const Entry &re) = 0;
 
 	/**
 	 * Compute a 64-bit value that hashes the current state of the network environment
 	 *
+	 * This shouldn't be overridden -- uses get() to get underlying routing table.
+	 *
 	 * @param ignoreInterfaces Names of interfaces to exclude from fingerprint (e.g. my own)
 	 * @return Integer CRC-type fingerprint of current network environment
 	 */
-	inline uint64_t networkEnvironmentFingerprint(const std::vector<std::string> &ignoreInterfaces) const
-	{
-		uint64_t fp = 0;
-		std::vector<Entry> rtab(routingTable());
-		for(std::vector<Entry>::const_iterator re(rtab.begin());re!=rtab.end();++re) {
-			bool skip = false;
-			for(std::vector<std::string>::const_iterator ii(ignoreInterfaces.begin());ii!=ignoreInterfaces.end();++ii) {
-				if (*ii == re->interface.device) {
-					skip = true;
-					break;
-				}
-			}
-			if (skip)
-				continue;
-			++fp;
-			if (re->destination.isV4()) {
-				fp = Utils::sdbmHash(re->destination.rawIpData(),4,fp);
-				fp = Utils::sdbmHash((uint16_t)re->destination.netmaskBits(),fp);
-			} else if (re->destination.isV6()) {
-				fp = Utils::sdbmHash(re->destination.rawIpData(),16,fp);
-				fp = Utils::sdbmHash((uint16_t)re->destination.netmaskBits(),fp);
-			}
-			if (re->gateway.isV4()) {
-				fp = Utils::sdbmHash(re->gateway.rawIpData(),4,fp);
-				fp = Utils::sdbmHash((uint16_t)re->gateway.netmaskBits(),fp);
-			} else if (re->gateway.isV6()) {
-				fp = Utils::sdbmHash(re->gateway.rawIpData(),16,fp);
-				fp = Utils::sdbmHash((uint16_t)re->gateway.netmaskBits(),fp);
-			}
-			fp = Utils::sdbmHash(re->device,fp);
-			fp = Utils::sdbmHash((uint32_t)re->metric,fp);
-		}
-		return fp;
-	}
+	uint64_t networkEnvironmentFingerprint(const std::vector<std::string> &ignoreInterfaces) const;
 };
 
 } // namespace ZeroTier