From 46f868bd4fb2fd7b0816ded98974935aacddf5e6 Mon Sep 17 00:00:00 2001 From: Adam Ierymenko Date: Wed, 16 Oct 2013 17:47:26 -0400 Subject: Lots of cleanup, more work on certificates, some security fixes. --- node/CertificateOfMembership.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'node/CertificateOfMembership.cpp') diff --git a/node/CertificateOfMembership.cpp b/node/CertificateOfMembership.cpp index c0385fb7..82e7bc81 100644 --- a/node/CertificateOfMembership.cpp +++ b/node/CertificateOfMembership.cpp @@ -163,15 +163,10 @@ bool CertificateOfMembership::agreesWith(const CertificateOfMembership &other) c // Compare to determine if the absolute value of the difference // between these two parameters is within our maxDelta. - uint64_t a = _qualifiers[myidx].value; - uint64_t b = other._qualifiers[myidx].value; - if (a >= b) { - if ((a - b) > _qualifiers[myidx].maxDelta) - return false; - } else { - if ((b - a) > _qualifiers[myidx].maxDelta) - return false; - } + const uint64_t a = _qualifiers[myidx].value; + const uint64_t b = other._qualifiers[myidx].value; + if (((a >= b) ? (a - b) : (b - a)) > _qualifiers[myidx].maxDelta) + return false; ++myidx; } -- cgit v1.2.3