From 3f71afd0fbb2d87a2c9288166299600da51470dc Mon Sep 17 00:00:00 2001 From: Adam Ierymenko Date: Fri, 26 Jun 2015 14:26:35 -0700 Subject: Put multicast txQueue back to list. --- node/Multicaster.cpp | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) (limited to 'node/Multicaster.cpp') diff --git a/node/Multicaster.cpp b/node/Multicaster.cpp index 8a15bac1..77ea2e66 100644 --- a/node/Multicaster.cpp +++ b/node/Multicaster.cpp @@ -275,12 +275,10 @@ void Multicaster::clean(uint64_t now) { Mutex::Lock _l(_groups_m); for(std::map< std::pair,MulticastGroupStatus >::iterator mm(_groups.begin());mm!=_groups.end();) { - for(std::vector::iterator tx(mm->second.txQueue.begin());tx!=mm->second.txQueue.end();) { - if ((tx->expired(now))||(tx->atLimit())) { - // erase element (replace by last) - *tx = mm->second.txQueue.back(); - mm->second.txQueue.pop_back(); - } else ++tx; + for(std::list::iterator tx(mm->second.txQueue.begin());tx!=mm->second.txQueue.end();) { + if ((tx->expired(now))||(tx->atLimit())) + mm->second.txQueue.erase(tx++); + else ++tx; } unsigned long count = 0; @@ -328,18 +326,14 @@ void Multicaster::_add(uint64_t now,uint64_t nwid,const MulticastGroup &mg,Multi //TRACE("..MC %s joined multicast group %.16llx/%s via %s",member.toString().c_str(),nwid,mg.toString().c_str(),((learnedFrom) ? learnedFrom.toString().c_str() : "(direct)")); - for(std::vector::iterator tx(gs.txQueue.begin());tx!=gs.txQueue.end();) { - if (tx->atLimit()) { - // erase element (replace by last) - *tx = gs.txQueue.back(); - gs.txQueue.pop_back(); - } else { + for(std::list::iterator tx(gs.txQueue.begin());tx!=gs.txQueue.end();) { + if (tx->atLimit()) + gs.txQueue.erase(tx++); + else { tx->sendIfNew(RR,member); - if (tx->atLimit()) { - // erase element (replace by last) - *tx = gs.txQueue.back(); - gs.txQueue.pop_back(); - } else ++tx; + if (tx->atLimit()) + gs.txQueue.erase(tx++); + else ++tx; } } } -- cgit v1.2.3