From f5d77a1bc21a61c12adb8b1254951a12b26db9e0 Mon Sep 17 00:00:00 2001 From: Adam Ierymenko Date: Mon, 12 Aug 2013 13:17:03 -0400 Subject: Clean up a bunch of valgrind errors, nix a potentially unsafe op in Buffer assignment operator. --- node/Buffer.hpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'node') diff --git a/node/Buffer.hpp b/node/Buffer.hpp index ed463bf6..14dd05c3 100644 --- a/node/Buffer.hpp +++ b/node/Buffer.hpp @@ -124,7 +124,7 @@ public: { if (b._l > C) throw std::out_of_range("Buffer: assignment from buffer larger than capacity"); - memcpy(this,&b,sizeof(_l) + b._l); // one memcpy for all fields + memcpy(_b,b._b,_l = b._l); return *this; } @@ -357,6 +357,15 @@ public: memset(_b + _l,0,C - _l); } + /** + * Unconditionally zero buffer's underlying memory + */ + inline void zeroAll() + throw() + { + memset(_b,0,sizeof(_b)); + } + /** * @return Size of data in buffer */ -- cgit v1.2.3