From 04de2302a7987d6046abed7b8c970488ed314e58 Mon Sep 17 00:00:00 2001
From: Joseph Henry <josephjah@gmail.com>
Date: Wed, 3 Oct 2018 14:24:21 -0700
Subject: More insightful errors for get command

---
 one.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'one.cpp')

diff --git a/one.cpp b/one.cpp
index b770451c..0b18ed91 100644
--- a/one.cpp
+++ b/one.cpp
@@ -630,7 +630,7 @@ static int cli(int argc,char **argv)
 		}
 	} else if (command == "get") {
 		if (arg1.length() != 16) {
-			cliPrintHelp(argv[0],stderr);
+			fprintf(stderr,"invalid network ID format, must be a 16-digit hexidecimal number\n");
 			return 2;
 		}
 		char jsons[1024], cl[128];
@@ -654,16 +654,21 @@ static int cli(int argc,char **argv)
 			printf("%u %s invalid JSON response (unknown exception)" ZT_EOL_S,scode,command.c_str());
 			return 1;
 		}
+		bool bNetworkFound = false;
 		if (j.is_array()) {
 			for(unsigned long i=0;i<j.size();++i) {
 				nlohmann::json &n = j[i];
 				if (n.is_object()) {
 					if (n["id"] == arg1) {
 						printf("%s\n", OSUtils::jsonString(n[arg2],"-").c_str());
+						bNetworkFound = true;
 					}
 				}
 			}
 		}
+		if (!bNetworkFound) {
+			fprintf(stderr,"unknown network ID, check that you are a member of the network\n");
+		}
 		if (scode == 200) {
 			return 0;
 		} else {
-- 
cgit v1.2.3


From 7dbccf08aeccab18be5fb24e90a6a1d89248aa3a Mon Sep 17 00:00:00 2001
From: Joseph Henry <josephjah@gmail.com>
Date: Tue, 23 Oct 2018 10:58:25 -0700
Subject: Removed unnecessary block before get request. Possible bug fix for
 Synology NAS ticket #27

---
 one.cpp | 4 ----
 1 file changed, 4 deletions(-)

(limited to 'one.cpp')

diff --git a/one.cpp b/one.cpp
index 0b18ed91..abe8bb37 100644
--- a/one.cpp
+++ b/one.cpp
@@ -633,10 +633,6 @@ static int cli(int argc,char **argv)
 			fprintf(stderr,"invalid network ID format, must be a 16-digit hexidecimal number\n");
 			return 2;
 		}
-		char jsons[1024], cl[128];
-		OSUtils::ztsnprintf(cl,sizeof(cl),"%u",(unsigned int)strlen(jsons));
-		requestHeaders["Content-Type"] = "application/json";
-		requestHeaders["Content-Length"] = cl;
 		const unsigned int scode = Http::GET(1024 * 1024 * 16,60000,(const struct sockaddr *)&addr,"/network",requestHeaders,responseHeaders,responseBody);
 
 		if (scode == 0) {
-- 
cgit v1.2.3