From 8b0c82d8bd01347874dcc9a493129082424a3649 Mon Sep 17 00:00:00 2001 From: Ken-ichirou MATSUZAWA Date: Sat, 7 Dec 2013 20:27:46 +0900 Subject: attr: validate MNL_TYPE_MSEC same as MNL_TYPE_U64 Signed-off-by: Ken-ichirou MATSUZAWA Signed-off-by: Florian Westphal --- src/attr.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/attr.c') diff --git a/src/attr.c b/src/attr.c index 1136c50..c3c57e6 100644 --- a/src/attr.c +++ b/src/attr.c @@ -200,6 +200,7 @@ static const size_t mnl_attr_data_type_len[MNL_TYPE_MAX] = { [MNL_TYPE_U16] = sizeof(uint16_t), [MNL_TYPE_U32] = sizeof(uint32_t), [MNL_TYPE_U64] = sizeof(uint64_t), + [MNL_TYPE_MSECS] = sizeof(uint64_t), }; /** -- cgit v1.2.3 From 72aec11703c7fda93af77cb6356f9692f18f9e9b Mon Sep 17 00:00:00 2001 From: Ken-ichirou MATSUZAWA Date: Fri, 24 Oct 2014 14:39:28 +0900 Subject: doc: minor fix mnl_attr_ok(): fix return value type mnl_attr_put_u8(): remove unused param - len mnl_attr_put_u8_check(): remove unused param - len mnl_nlmsg_ok(): fix return value type mnl_nlmsg_batch_stop(): not return batch size, but release it Signed-off-by: Ken-ichirou MATSUZAWA Signed-off-by: Florian Westphal --- src/attr.c | 4 +--- src/nlmsg.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) (limited to 'src/attr.c') diff --git a/src/attr.c b/src/attr.c index c3c57e6..ca2cd25 100644 --- a/src/attr.c +++ b/src/attr.c @@ -89,7 +89,7 @@ EXPORT_SYMBOL(mnl_attr_get_payload); * truncated. * * This function does not set errno in case of error since it is intended - * for iterations. Thus, it returns 1 on success and 0 on error. + * for iterations. Thus, it returns true on success and false on error. * * The len parameter may be negative in the case of malformed messages during * attribute iteration, that is why we use a signed integer. @@ -428,7 +428,6 @@ EXPORT_SYMBOL(mnl_attr_put); * mnl_attr_put_u8 - add 8-bit unsigned integer attribute to netlink message * \param nlh pointer to the netlink message * \param type netlink attribute type - * \param len netlink attribute payload size * \param data 8-bit unsigned integer data that is stored by the new attribute * * This function updates the length field of the Netlink message (nlmsg_len) @@ -569,7 +568,6 @@ EXPORT_SYMBOL(mnl_attr_put_check); * \param nlh pointer to the netlink message * \param buflen size of buffer which stores the message * \param type netlink attribute type - * \param len netlink attribute payload size * \param data 8-bit unsigned integer data that is stored by the new attribute * * This function first checks that the data can be added to the message diff --git a/src/nlmsg.c b/src/nlmsg.c index fdb7af8..fd2f698 100644 --- a/src/nlmsg.c +++ b/src/nlmsg.c @@ -150,7 +150,7 @@ EXPORT_SYMBOL(mnl_nlmsg_get_payload_offset); * truncated. * * This function does not set errno in case of error since it is intended - * for iterations. Thus, it returns 1 on success and 0 on error. + * for iterations. Thus, it returns true on success and false on error. * * The len parameter may become negative in malformed messages during message * iteration, that is why we use a signed integer. @@ -462,7 +462,7 @@ EXPORT_SYMBOL(mnl_nlmsg_batch_start); * mnl_nlmsg_batch_stop - release a batch * \param b pointer to batch * - * This function returns the amount of data that is part of this batch. + * This function releases the batch allocated by mnl_nlmsg_batch_start(). */ void mnl_nlmsg_batch_stop(struct mnl_nlmsg_batch *b) { -- cgit v1.2.3 From c9f19b98cd8e108617e825e071091df14f78c53a Mon Sep 17 00:00:00 2001 From: Hisao Tanabe Date: Sat, 10 Jan 2015 18:02:07 +0900 Subject: attr: minor doc fix in mnl_attr_next() mnl_attr_next(): remove unused param - len Signed-off-by: Hisao Tanabe Signed-off-by: Pablo Neira Ayuso --- src/attr.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/attr.c') diff --git a/src/attr.c b/src/attr.c index ca2cd25..c551d0b 100644 --- a/src/attr.c +++ b/src/attr.c @@ -105,7 +105,6 @@ EXPORT_SYMBOL(mnl_attr_ok); /** * mnl_attr_next - get the next attribute in the payload of a netlink message * \param attr pointer to the current attribute - * \param len length of the remaining bytes in the buffer (passed by reference). * * This function returns a pointer to the next attribute after the one passed * as parameter. You have to use mnl_attr_ok() to ensure that the next -- cgit v1.2.3