Age | Commit message (Collapse) | Author |
|
|
|
Various cryptography improvements
|
|
Also, correct the -DTACDEBUG_AT_RUNTIME scenario so that TACDEBUG()
binds correct when used in an if-body with an else following it, e.g.:
if (test)
TACDEBUG(LOG_DEBUG, "test is true");
else
return;
would previously have ended up as expanding to:
if (test)
if (tac_debug_enable) logmsg(LOG_DEBUG, "test is true");
else
return;
with the indent redone to reflect the nesting correctly. This now
expands (correctly) to:
if (test)
do { if (tac_debug_enable) logmsg(LOG_DEBUG, "test is true"); } while (0);
else
return;
|
|
Why make copies of the payload length to pass as parameters when
it's already present in the header?
|
|
|
|
And fix subsequent warnings caused by:
- shadowed variables (i.e. variables existing in nested scopes);
- signed vs. unsigned comparisons
- string pointers and buffers being unsigned which don't need to be;
- unnecessary casts;
- unused variables (or only used when debugging is enabled);
|
|
|
|
|
|
|
|
|
|
Fix various declaration inconsistencies that were throwing compiler
warnings
|
|
|
|
|
|
|
|
|
|
|
|
|
|
past the actual packet data
|
|
Messages like "Args cnt %d", "Adding buf/value pair (%s,%s)" should not
flood syslog as warning.
|
|
Protocol is only required for certain subset of services, mainly for ppp. We
allow authorization with empty protocol if user wants to use other service
names, like 'ssh'
From the http://tools.ietf.org/html/draft-grant-tacacs-02 page 30:
The protocol attribute is intended for use with PPP. When service equals
"ppp" and protocol equals "lcp", the message describes the PPP link
layer service. For other values of protocol, this describes a PPP NCP
(network layer service). A single PPP session can support multiple NCPs
|
|
|
|
|
|
|
|
|
|
|