From 50c0e0a61fd15636a12a2bdece548f78ff8dfe93 Mon Sep 17 00:00:00 2001 From: pwdng Date: Tue, 14 Oct 2014 18:12:17 +0200 Subject: Close /dev/urandom to fix open file handler leak. --- libtac/lib/magic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libtac/lib/magic.c b/libtac/lib/magic.c index 308dc03..9785314 100644 --- a/libtac/lib/magic.c +++ b/libtac/lib/magic.c @@ -77,8 +77,10 @@ magic() if(rfd > -1) { u_int32_t ret; + int nb_read = read(rfd, &ret, sizeof(ret)); + close(rfd); - if (read(rfd, &ret, sizeof(ret)) < sizeof(ret)) { + if (nb_read < sizeof(ret)) { /* on read() error fallback to other method */ return (u_int32_t)random(); } -- cgit v1.2.3