From e1bc8e8314544a5affcad33d132352bd8d3d69f2 Mon Sep 17 00:00:00 2001 From: Walter de Jong Date: Fri, 22 Mar 2013 22:54:00 +0100 Subject: added two FIXME remarks --- support.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/support.c b/support.c index ad44829..dc7cea1 100644 --- a/support.c +++ b/support.c @@ -44,6 +44,9 @@ char *tac_prompt = NULL; extern char *tac_login; extern int tac_timeout; +/* + FIXME using xcalloc() leaks memory for long-running programs that authenticate multiple times +*/ #ifndef xcalloc void *_xcalloc (size_t size) { register void *val = calloc (1, size); @@ -280,6 +283,9 @@ int _pam_parse (int argc, const char **argv) { } if (tac_srv_key_no == 0) { + /* FIXME this should really be NULL + but watch out with breaking other code + */ tac_srv_key[0] = ""; tac_srv_key_no++; } -- cgit v1.2.3