Phorge full-text search extension for Elasticsearch 7.x / 8.x / OpenSearch via the typeless API (mirror of https://github.com/vyos/phorge-elasticsearch-modern.git) https://git.amelek.net/vyos/phorge-elasticsearch-modern.git/atom?h=development 2026-05-23T12:48:18+00:00 2026-05-23T12:48:18+00:00 Yuriy Andamasov yuriy@vyos.io 2026-05-23T12:48:18+00:00 urn:sha1:011eec12f9176a6a8b8d8b9133bc00107a7855c0 A recent fixup cascade declared VyOSElasticModernFulltextStorageEngine as 'abstract class' to enable test-doubling subclasses (VyOSElasticModernHostTestEngine, VyOSElasticModernFulltextStorageEngineTestDouble). That change broke production dispatch: Phorge's PhutilClassMapQuery selects engines via PhutilSymbolLoader::loadObjects(), which calls setConcreteOnly(true) and unsets any class where reflection reports isAbstract(). The engine class would no longer be discoverable by cluster.search[].type:elasticsearch-modern, and the test-fixture subclasses live in src/__tests__/ which libphutil excludes from runtime class-map loading. Revert to plain 'class' (not 'final', not 'abstract'). Plain 'class' is discoverable by PhutilClassMapQuery; existing test fixtures keep working without rewrite; operators can subclass if they need to (harmless). Also update VyOSElasticModernHostTestCase::testPlaceholderEngineIsAbstract → testEngineIsConcreteForDispatch, inverting the assertion to document the correct invariant and its rationale (setConcreteOnly reference). All 22 tests pass. 🤖 Generated by [robots](https://vyos.io) 2026-05-22T09:59:41+00:00 copilot-swe-agent[bot] 198982749+Copilot@users.noreply.github.com 2026-05-22T09:59:41+00:00 urn:sha1:5e97aa48c13f75537915018754339b2336f14c1a 2026-05-22T07:52:57+00:00 Yuriy Andamasov yuriy@vyos.io 2026-05-22T07:52:57+00:00 urn:sha1:40775baed5c08582b1976d1a1fa054ad0e192826 - Engine class marked final (matches host class declaration; no design intent to subclass). - testConfigOverrides now also asserts host and port (these were the most-likely-to-be-misconfigured fields; previously set but unverified). 🤖 Generated by [robots](https://vyos.io) 2026-05-22T07:43:48+00:00 Yuriy Andamasov yuriy@vyos.io 2026-05-22T07:43:48+00:00 urn:sha1:77fdd523554e18abc3a834bbd52527f015bc4aa8 Host class mirrors PhabricatorElasticsearchHost's surface. Engine is a stub providing only getEngineIdentifier() and getHostType() so the host's tests can construct an engine instance; real engine implementation lands in subsequent commits. All six abstract methods of PhabricatorFulltextStorageEngine are implemented (four as throwing stubs to be replaced in E7/E8). .arcconfig gains "src/" in the load list so arc unit can discover the extension library; test case extends PhutilTestCase (no DB needed for pure-PHP host property assertions). 🤖 Generated by [robots](https://vyos.io)