From 54a3c5c32c14295d82268e446acfd9df26438cd7 Mon Sep 17 00:00:00 2001 From: omnom62 Date: Sat, 3 Oct 2026 14:53:48 +1000 Subject: T8989: interfaces AI comment fixed --- tests/unit/modules/test_vyos_interfaces.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'tests/unit/modules') diff --git a/tests/unit/modules/test_vyos_interfaces.py b/tests/unit/modules/test_vyos_interfaces.py index af0687b..56683df 100644 --- a/tests/unit/modules/test_vyos_interfaces.py +++ b/tests/unit/modules/test_vyos_interfaces.py @@ -601,6 +601,18 @@ class TestBuildCommands(VyOSModuleTestCase): cmds, ) + def test_merged_never_reenables_an_unlisted_vif(self): + """CodeRabbit regression: merged's re-enable logic previously + scanned every disabled VIF on the device, not just ones the + task actually lists -- so a VLAN the administrator + deliberately disabled would be silently re-enabled by a task + that never even mentions "vifs" at all. merged must leave an + unlisted VIF completely untouched, same as any other unlisted + field.""" + raw_have = _FIXTURES["vif_disabled_on_device"] + cmds = build_commands([{"name": "eth0", "description": "x"}], raw_have, "merged") + self.assertFalse(any("200" in c[1] for c in cmds)) + def test_merged_new_interface_with_vrf_and_vif(self): config = [ { -- cgit v1.2.3