diff options
author | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2009-02-03 08:58:47 -0800 |
---|---|---|
committer | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2009-02-03 08:58:47 -0800 |
commit | 307ad82ec971104519c3e3df2ad05dc376528809 (patch) | |
tree | 7074ffdb8c0ba1816576f1f367e04032afed136c /lib/Vyatta/IpTables/IpSet.pm | |
parent | 670de26785f26e7ead9ec9ffbca8f96c1689bdd6 (diff) | |
download | vyatta-cfg-firewall-307ad82ec971104519c3e3df2ad05dc376528809.tar.gz vyatta-cfg-firewall-307ad82ec971104519c3e3df2ad05dc376528809.zip |
Fix perlcritic warnings
Should not explicitly return undef
Diffstat (limited to 'lib/Vyatta/IpTables/IpSet.pm')
-rwxr-xr-x | lib/Vyatta/IpTables/IpSet.pm | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/Vyatta/IpTables/IpSet.pm b/lib/Vyatta/IpTables/IpSet.pm index c8508c6..3410c03 100755 --- a/lib/Vyatta/IpTables/IpSet.pm +++ b/lib/Vyatta/IpTables/IpSet.pm @@ -96,7 +96,7 @@ sub create { my $rc = system("sudo $cmd"); system("$logger [$func] [$cmd] = [$rc]") if defined $self->{_debug}; return "Error: call to ipset failed [$rc]" if $rc; - return undef; + return; # undef } sub references { @@ -126,7 +126,7 @@ sub delete { my $rc = system("sudo $cmd"); system("$logger [$func] [$cmd] = [$rc]") if defined $self->{_debug}; return "Error: call to ipset failed [$rc]" if $rc; - return undef; + return; # undef } sub check_member { @@ -158,7 +158,7 @@ sub check_member { } else { return "Error: invalid set type [$self->{_type}]"; } - return undef; + return; #undef } sub member_exists { @@ -185,7 +185,7 @@ sub add_member { my $rc = system("sudo $cmd"); system("$logger [$func] [$cmd] = [$rc]") if defined $self->{_debug}; return "Error: call to ipset failed [$rc]" if $rc; - return undef; + return; # undef } sub delete_member { @@ -202,7 +202,7 @@ sub delete_member { my $rc = system("sudo $cmd"); system("$logger [$func] [$cmd] = [$rc]") if defined $self->{_debug}; return "Error: call to ipset failed [$rc]" if $rc; - return undef; + return; # undef } sub rule { |