From f9cf46359e923ffab788663a8d644b06bfe0e9b5 Mon Sep 17 00:00:00 2001 From: Stig Thormodsrud Date: Fri, 6 Feb 2009 12:09:26 -0800 Subject: Add validation of group type. --- scripts/firewall/vyatta-ipset.pl | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'scripts') diff --git a/scripts/firewall/vyatta-ipset.pl b/scripts/firewall/vyatta-ipset.pl index 0c0ee86..fe3a921 100755 --- a/scripts/firewall/vyatta-ipset.pl +++ b/scripts/firewall/vyatta-ipset.pl @@ -77,6 +77,22 @@ sub ipset_delete_member { return $group->delete_member($member); } +sub ipset_check_set_type { + my ($set_name, $set_type) = @_; + + die "Error: undefined set_name\n" if ! defined $set_name; + die "Error: undefined set_type\n" if ! defined $set_type; + + my $group = new Vyatta::IpTables::IpSet($set_name); + return "Group [$set_name] has not been defined\n" if ! $group->exists(); + my $type = $group->get_type(); + $type = 'undefined' if ! defined $type; + if ($type ne $set_type) { + return "Error: group [$set_name] is of type [$type] not [$set_type]"; + } + return; +} + # # main @@ -103,6 +119,8 @@ $rc = ipset_add_member($set_name, $member) if $action eq 'add-member'; $rc = ipset_delete_member($set_name, $member) if $action eq 'delete-member'; +$rc = ipset_check_set_type($set_name, $set_type) if $action eq 'check-set-type'; + if (defined $rc) { print $rc; exit 1; -- cgit v1.2.3