diff options
| author | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2010-07-13 14:26:58 -0700 |
|---|---|---|
| committer | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2010-07-13 14:26:58 -0700 |
| commit | a5c9214ec6b46d6a936303dcdce44ccf2ad83f8c (patch) | |
| tree | c06ba97fc8a6aa7ccfdab84aa19f2e568f9aa790 | |
| parent | c889f2bbad0c9585d7525a1b5d6b0d7c707142fc (diff) | |
| download | vyatta-cfg-qos-a5c9214ec6b46d6a936303dcdce44ccf2ad83f8c.tar.gz vyatta-cfg-qos-a5c9214ec6b46d6a936303dcdce44ccf2ad83f8c.zip | |
Require queue limit to be greater than zero
Since queue limit of zero causes all packets to be dropped;
require user to configure a reasonable value
Bug 5842
8 files changed, 9 insertions, 2 deletions
diff --git a/templates/traffic-policy/drop-tail/node.tag/queue-limit/node.def b/templates/traffic-policy/drop-tail/node.tag/queue-limit/node.def index fe3b4dd..55c584b 100644 --- a/templates/traffic-policy/drop-tail/node.tag/queue-limit/node.def +++ b/templates/traffic-policy/drop-tail/node.tag/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 -help: Set maximum queue size (packets) [REQUIRED] +help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0 ; "queue limit must be greater than zero" diff --git a/templates/traffic-policy/fair-queue/node.tag/queue-limit/node.def b/templates/traffic-policy/fair-queue/node.tag/queue-limit/node.def index 471bd5b..92c4349 100644 --- a/templates/traffic-policy/fair-queue/node.tag/queue-limit/node.def +++ b/templates/traffic-policy/fair-queue/node.tag/queue-limit/node.def @@ -1,3 +1,3 @@ type: u32 -syntax:expression: $VAR(@) > 1 ; "Queue limit must greater than 1" help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 1 ; "Queue limit must greater than 1" diff --git a/templates/traffic-policy/network-emulator/node.tag/queue-limit/node.def b/templates/traffic-policy/network-emulator/node.tag/queue-limit/node.def index 49c47b4..d86b23d 100644 --- a/templates/traffic-policy/network-emulator/node.tag/queue-limit/node.def +++ b/templates/traffic-policy/network-emulator/node.tag/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0; "Queue limit must be greater than zero" diff --git a/templates/traffic-policy/random-detect/node.tag/precedence/node.tag/queue-limit/node.def b/templates/traffic-policy/random-detect/node.tag/precedence/node.tag/queue-limit/node.def index 49c47b4..bac5c2a 100644 --- a/templates/traffic-policy/random-detect/node.tag/precedence/node.tag/queue-limit/node.def +++ b/templates/traffic-policy/random-detect/node.tag/precedence/node.tag/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0 ; "Queue limit must greater than zero" diff --git a/templates/traffic-policy/round-robin/node.tag/class/node.tag/queue-limit/node.def b/templates/traffic-policy/round-robin/node.tag/class/node.tag/queue-limit/node.def index 49c47b4..bac5c2a 100644 --- a/templates/traffic-policy/round-robin/node.tag/class/node.tag/queue-limit/node.def +++ b/templates/traffic-policy/round-robin/node.tag/class/node.tag/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0 ; "Queue limit must greater than zero" diff --git a/templates/traffic-policy/round-robin/node.tag/default/queue-limit/node.def b/templates/traffic-policy/round-robin/node.tag/default/queue-limit/node.def index 49c47b4..bac5c2a 100644 --- a/templates/traffic-policy/round-robin/node.tag/default/queue-limit/node.def +++ b/templates/traffic-policy/round-robin/node.tag/default/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0 ; "Queue limit must greater than zero" diff --git a/templates/traffic-policy/shaper/node.tag/class/node.tag/queue-limit/node.def b/templates/traffic-policy/shaper/node.tag/class/node.tag/queue-limit/node.def index 49c47b4..d86b23d 100644 --- a/templates/traffic-policy/shaper/node.tag/class/node.tag/queue-limit/node.def +++ b/templates/traffic-policy/shaper/node.tag/class/node.tag/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0; "Queue limit must be greater than zero" diff --git a/templates/traffic-policy/shaper/node.tag/default/queue-limit/node.def b/templates/traffic-policy/shaper/node.tag/default/queue-limit/node.def index 49c47b4..14b710d 100644 --- a/templates/traffic-policy/shaper/node.tag/default/queue-limit/node.def +++ b/templates/traffic-policy/shaper/node.tag/default/queue-limit/node.def @@ -1,2 +1,3 @@ type: u32 help: Set maximum queue size (packets) +syntax:expression: $VAR(@) > 0; "Queue limit must be greater than zero" |