diff options
author | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2009-01-25 17:45:39 +1100 |
---|---|---|
committer | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2009-01-25 17:45:39 +1100 |
commit | d04d08a2ec678ade4c1b97f4fba4ff89b6ddde43 (patch) | |
tree | 9100496c0f7773fc1a3dd0ac950944e18d41f591 /scripts | |
parent | 7bfafa9310bb3502ef6ce1cd8f62b77bb76d513b (diff) | |
download | vyatta-cfg-qos-d04d08a2ec678ade4c1b97f4fba4ff89b6ddde43.tar.gz vyatta-cfg-qos-d04d08a2ec678ade4c1b97f4fba4ff89b6ddde43.zip |
Fix perl critic warning
Make loop variables local
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/vyatta-qos.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/vyatta-qos.pl b/scripts/vyatta-qos.pl index 5db9025..20c56bf 100755 --- a/scripts/vyatta-qos.pl +++ b/scripts/vyatta-qos.pl @@ -60,7 +60,7 @@ sub make_policy { if ($direction) { $policy_type = $policies{$direction}{$type}; } else { - foreach $direction (keys %policies) { + foreach my $direction (keys %policies) { $policy_type = $policies{$direction}{$type}; last if defined $policy_type; } @@ -68,7 +68,7 @@ sub make_policy { # This means template exists but we don't know what it is. if (! defined $policy_type) { - foreach $direction (keys %policies) { + foreach my $direction (keys %policies) { die "QoS policy $name is type $type and is only valid for $direction\n" if defined $policies{$direction}{$type}; } |