From 5dd7c609b10fb7634b59e8c581b8f832f65c9860 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 29 May 2009 10:01:47 -0700 Subject: Need to require network delay Packet reordering doesn't work unless there are packets in the queue, and no packets are held unless there is a delay. --- .../qos-policy/network-emulator/node.tag/packet-reordering/node.def | 2 ++ 1 file changed, 2 insertions(+) diff --git a/templates/qos-policy/network-emulator/node.tag/packet-reordering/node.def b/templates/qos-policy/network-emulator/node.tag/packet-reordering/node.def index 5eb7261..278d4a5 100644 --- a/templates/qos-policy/network-emulator/node.tag/packet-reordering/node.def +++ b/templates/qos-policy/network-emulator/node.tag/packet-reordering/node.def @@ -1,6 +1,8 @@ type: txt help: Set emulated packet reordering percentage syntax:expression: exec "/opt/vyatta/sbin/vyatta-qos-util.pl --percent \"$VAR(@)\"" +commit:expression: $VAR(../network-delay) != "" ; \ + "Must specify network-delay for packet reordering" comp_help: Allowed values: %% Percentage of packets affected -- cgit v1.2.3