From 7f78fa942890465cace2e478c7f0795991722074 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Tue, 8 Jul 2008 13:29:57 -0700
Subject: validate traffic shaper rates at commit time if possible

Bugfix 2919
As long as the bandwidth isn't auto, then validate at commit time.
---
 scripts/VyattaQosTrafficShaper.pm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/scripts/VyattaQosTrafficShaper.pm b/scripts/VyattaQosTrafficShaper.pm
index 6b76eb0..28c84cb 100644
--- a/scripts/VyattaQosTrafficShaper.pm
+++ b/scripts/VyattaQosTrafficShaper.pm
@@ -253,9 +253,27 @@ sub new {
     bless $self, $class;
     $self->_define($config);
 
+    $self->_validate($config);
+
     return $self;
 }
 
+sub _validate {
+    my $self = shift;
+
+    if ( $self->{_rate} ne "auto" ) {
+	my $classes = $self->{_classes};
+	my $default = shift @$classes;
+	my $rate = VyattaQosUtil::getRate($self->{_rate});
+
+	$default->rateCheck($rate, "$self->{_level} default");
+
+	foreach my $class (@$classes) {
+	    $class->rateCheck($rate, "$self->{_level} class $class->{id}");
+	}
+    }
+}
+
 # Rate can be something like "auto" or "10.2mbit"
 sub _getAutoRate {
     my ($rate, $dev) = @_;
-- 
cgit v1.2.3


From 9a25dee29ff200647e6b0f6b6dc58b0aade39a52 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Fri, 11 Jul 2008 17:16:55 -0700
Subject: Retry to find interface speed

Bugfix 3450
If device is offline, can't find speed. So use a sensible default
and try a few times.
---
 scripts/VyattaQosUtil.pm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/scripts/VyattaQosUtil.pm b/scripts/VyattaQosUtil.pm
index f847116..eca0ca3 100644
--- a/scripts/VyattaQosUtil.pm
+++ b/scripts/VyattaQosUtil.pm
@@ -220,17 +220,28 @@ sub getIfIndex {
 # return result in bits per second
 sub interfaceRate {
     my ($interface) = @_;
+    my $speed;
     my $config = new VyattaConfig;
 
     $config->setLevel("interfaces ethernet");
     if ($config->exists("$interface")) {
-	my $speed  = $config->returnValue("$interface speed");
+	$speed  = $config->returnValue("$interface speed");
 	if (defined($speed) && $speed ne "auto") {
 	    return $speed * 1000000;
 	}
     } 
 
-    return ethtoolRate($interface);
+    # During boot it may take time for auto-negotiation
+    for (my $retries = 0; $retries < 5; $retries++) {
+	$speed = ethtoolRate($interface);
+	if (defined $speed) {
+	    return $speed;
+	}
+	sleep 1;
+    }
+
+    warn "Could not determine speed for $interface, assuming 100mbit\n";
+    return 100 * 1000000;
 }
 
 ## ethtoolRate("eth0")
-- 
cgit v1.2.3