From 237415c05a9ab70bca8ec416a7fcdbb5dc291f20 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 10 Jun 2008 08:39:08 -0700 Subject: Fix error messages for misconfiguration One more try at explaining why rates must be correct. --- scripts/VyattaQosTrafficShaper.pm | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) (limited to 'scripts') diff --git a/scripts/VyattaQosTrafficShaper.pm b/scripts/VyattaQosTrafficShaper.pm index 8e7c1e3..9564c43 100644 --- a/scripts/VyattaQosTrafficShaper.pm +++ b/scripts/VyattaQosTrafficShaper.pm @@ -106,15 +106,22 @@ my $rate = _getPercentRate($self->{_rate}, $limit); if ($rate > $limit) { - printf STDERR - "Warning: $level\nbandwidth %dKbps > overall bandwidth %dKbps\n", - $rate / 1000, $limit / 1000; + print "Configuration error in: $level\n"; + printf STDERR "The bandwidth reserved for this class (%dKbps) must be", + $rate / 1000; + printf STDERR "less than the bandwidth for the overall policy (%dKbps)\n", + $limit / 1000; + exit 1; } my $ceil = _getPercentRate($self->{_ceiling}, $limit); if (defined $ceil && $ceil < $rate) { - die "$level\nceiling %dKbps < class bandwidth %dKbps\n", - $ceil / 1000, $rate / 1000; + print "Configuration error in: $level\n"; + printf STDERR "The bandwidth ceiling for this class (%dKbps) must be", + $ceil / 1000; + printf STDERR "less than the reserved bandwidth for the class (%dKbps)\n", + $rate / 1000; + exit 1; } } -- cgit v1.2.3