From 72728a87d04ab3027960f7667840e4d4f781bb7d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 14 Feb 2008 12:10:00 -0800 Subject: use sudo to run ethtool But do it in a manner safe from quoting attacks! --- scripts/VyattaQosUtil.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'scripts') diff --git a/scripts/VyattaQosUtil.pm b/scripts/VyattaQosUtil.pm index 86b091a..1e77179 100644 --- a/scripts/VyattaQosUtil.pm +++ b/scripts/VyattaQosUtil.pm @@ -169,7 +169,9 @@ sub ethtoolRate { my ($dev) = @_; my $rate = undef; - open my $ethtool, "ethtool $dev |" or die "ethtool failed: $!\n"; + open my $ethtool, "-|" + or exec 'sudo', 'ethtool', $dev + or die "ethtool failed: $!\n"; # ethtool produces: # -- cgit v1.2.3