From 7f78fa942890465cace2e478c7f0795991722074 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Jul 2008 13:29:57 -0700 Subject: validate traffic shaper rates at commit time if possible Bugfix 2919 As long as the bandwidth isn't auto, then validate at commit time. --- scripts/VyattaQosTrafficShaper.pm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'scripts') diff --git a/scripts/VyattaQosTrafficShaper.pm b/scripts/VyattaQosTrafficShaper.pm index 6b76eb0..28c84cb 100644 --- a/scripts/VyattaQosTrafficShaper.pm +++ b/scripts/VyattaQosTrafficShaper.pm @@ -253,9 +253,27 @@ sub new { bless $self, $class; $self->_define($config); + $self->_validate($config); + return $self; } +sub _validate { + my $self = shift; + + if ( $self->{_rate} ne "auto" ) { + my $classes = $self->{_classes}; + my $default = shift @$classes; + my $rate = VyattaQosUtil::getRate($self->{_rate}); + + $default->rateCheck($rate, "$self->{_level} default"); + + foreach my $class (@$classes) { + $class->rateCheck($rate, "$self->{_level} class $class->{id}"); + } + } +} + # Rate can be something like "auto" or "10.2mbit" sub _getAutoRate { my ($rate, $dev) = @_; -- cgit v1.2.3