diff options
| author | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2010-04-05 22:07:22 -0700 |
|---|---|---|
| committer | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2010-04-05 22:07:22 -0700 |
| commit | ecc62d95b95fd802dec09a3e0707eb536bf26960 (patch) | |
| tree | 9db7ad633975acc72cdaee4d2ef518841d85ca0c | |
| parent | d5677543ecf83d7ab4ac191cf2160060e8429797 (diff) | |
| download | vyatta-cfg-quagga-ecc62d95b95fd802dec09a3e0707eb536bf26960.tar.gz vyatta-cfg-quagga-ecc62d95b95fd802dec09a3e0707eb536bf26960.zip | |
Use 3 arg open
This fixes perlcritic warning because of using 2 arg open.
The other form puts pipe as method.
| -rwxr-xr-x | scripts/vyatta-interfaces.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/vyatta-interfaces.pl b/scripts/vyatta-interfaces.pl index cbb6abf6..90a4e0f9 100755 --- a/scripts/vyatta-interfaces.pl +++ b/scripts/vyatta-interfaces.pl @@ -544,7 +544,7 @@ sub show_config_path { sub get_ethtool { my $dev = shift; - open( my $ethtool, "sudo /usr/sbin/ethtool $dev 2>/dev/null |" ) + open( my $ethtool, "-|", "sudo /usr/sbin/ethtool $dev 2>/dev/null" ) or die "ethtool failed: $!\n"; # ethtool produces: |