summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniil Baturin <daniil@baturin.org>2017-10-13 01:21:09 +0200
committerDaniil Baturin <daniil@baturin.org>2017-10-13 01:29:48 +0200
commiteabbef4dd3b3e9a6a4cff57f72d2c82d88294968 (patch)
tree865b968011425e565804a7bca8cecbe17fa93bf0
parent0ae4efd7ffee5348cf2b8754e9bda5cf6aa7a4c5 (diff)
downloadvyatta-cfg-quagga-eabbef4dd3b3e9a6a4cff57f72d2c82d88294968.tar.gz
vyatta-cfg-quagga-eabbef4dd3b3e9a6a4cff57f72d2c82d88294968.zip
T87: make non-assigned update-source address a warning rather than an error.
Making it an error prevents configuration from loading, which has adverse interaction with non-permanent interfaces such as certain VPN tunnels that may not immediately go up. A dead BGP session is lesser of two evils compared to incomplete configuration.
-rwxr-xr-xscripts/bgp/vyatta-bgp.pl4
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/bgp/vyatta-bgp.pl b/scripts/bgp/vyatta-bgp.pl
index 1fc1e3c1..ce653683 100755
--- a/scripts/bgp/vyatta-bgp.pl
+++ b/scripts/bgp/vyatta-bgp.pl
@@ -1558,10 +1558,10 @@ sub check_source {
if ($ip) {
my $found = grep { my $a = new NetAddr::IP::Lite($_);
$a->addr() eq $ip->addr() } Vyatta::Misc::getIP();
- die "IP address $ip does not exist on this system\n" if ($found == 0);
+ print("Warning: IP address $ip does not exist on this system\n") if ($found == 0);
} else {
my $found = grep { $_ eq $src } Vyatta::Misc::getInterfaces();
- die "Interface $src does not exist on the system\n" if ($found == 0);
+ print("Warning: Interface $src does not exist on the system\n") if ($found == 0);
}
}