* perltidy vyatta-keepalived.pl

1 files changed, 401 insertions, 391 deletions

diff --git a/scripts/keepalived/vyatta-keepalived.pl b/scripts/keepalived/vyatta-keepalived.pl
index 4ade0394..d06b9e36 100755
--- a/scripts/keepalived/vyatta-keepalived.pl
+++ b/scripts/keepalived/vyatta-keepalived.pl
@@ -1,12 +1,12 @@
 #!/usr/bin/perl
 #
 # Module: vyatta-keepalived.pl
-# 
+#
 # **** License ****
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 2 as
 # published by the Free Software Foundation.
-# 
+#
 # This program is distributed in the hope that it will be useful, but
 # WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
@@ -15,11 +15,11 @@
 # This code was originally developed by Vyatta, Inc.
 # Portions created by Vyatta are Copyright (C) 2007-2009 Vyatta, Inc.
 # All Rights Reserved.
-# 
+#
 # Author: Stig Thormodsrud
 # Date: October 2007
 # Description: Script to glue vyatta cli to keepalived daemon
-# 
+#
 # **** End License ****
 #
 
@@ -35,40 +35,41 @@ use Getopt::Long;
 use strict;
 use warnings;
 
-my ($action, $vrrp_intf, $vrrp_group, $vrrp_vip, $ctsync);
-my ($conf_file, $changes_file);
+my ( $action, $vrrp_intf, $vrrp_group, $vrrp_vip, $ctsync );
+my ( $conf_file, $changes_file );
 my %HoA_sync_groups;
 my $ctsync_script = "/opt/vyatta/sbin/vyatta-vrrp-conntracksync.sh";
 
 sub validate_source_addr {
-    my ($ifname, $source_addr) = @_;
-
-    my @ipaddrs;
-    if (defined $source_addr) {
-	my %config_ipaddrs;
-	my @ipaddrs = Vyatta::Misc::getInterfacesIPadresses('all');
-	foreach my $ip (@ipaddrs) {
-	    if ($ip =~ /^([\d.]+)\/([\d.]+)$/) { # strip /mask
-		$config_ipaddrs{$1} = 1;
-	    }
-	}
-	if (!defined $config_ipaddrs{$source_addr}) {
-	    vrrp_log("no hello-source");
-	    return "hello-source-address [$source_addr] must be " . 
-		"configured on the interface\n";
-	}
-	return;
+  my ( $ifname, $source_addr ) = @_;
+
+  my @ipaddrs;
+  if ( defined $source_addr ) {
+    my %config_ipaddrs;
+    my @ipaddrs = Vyatta::Misc::getInterfacesIPadresses('all');
+    foreach my $ip (@ipaddrs) {
+      if ( $ip =~ /^([\d.]+)\/([\d.]+)$/ ) {    # strip /mask
+        $config_ipaddrs{$1} = 1;
+      }
     }
-    # if the hello-source-address wasn't configured, check that the
-    # interface has an IPv4 address configured on it.
-    my $intf = new Vyatta::Interface($ifname);
-    @ipaddrs = $intf->address(4);
-    if (scalar(@ipaddrs) < 1) {
-	vrrp_log("no primary or hello-source");
-	return "must configure either a primary address on [$ifname] or" .
-	    " a hello-source-address\n";
+    if ( !defined $config_ipaddrs{$source_addr} ) {
+      vrrp_log("no hello-source");
+      return "hello-source-address [$source_addr] must be "
+        . "configured on the interface\n";
     }
     return;
+  }
+
+  # if the hello-source-address wasn't configured, check that the
+  # interface has an IPv4 address configured on it.
+  my $intf = new Vyatta::Interface($ifname);
+  @ipaddrs = $intf->address(4);
+  if ( scalar(@ipaddrs) < 1 ) {
+    vrrp_log("no primary or hello-source");
+    return "must configure either a primary address on [$ifname] or"
+      . " a hello-source-address\n";
+  }
+  return;
 }
 
 sub get_ctsync_syncgrp {
@@ -77,358 +78,366 @@ sub get_ctsync_syncgrp {
 
   my $listnodesfunc = "listNodes";
   my $returnvalfunc = "returnValue";
-  if (defined $origfunc) {
+  if ( defined $origfunc ) {
     $listnodesfunc = "listOrigNodes";
     $returnvalfunc = "returnOrigValue";
   }
 
-  my @failover_mechanism = Vyatta::ConntrackSync::get_conntracksync_val(
-        $listnodesfunc, "failover-mechanism" );
+  my @failover_mechanism =
+    Vyatta::ConntrackSync::get_conntracksync_val( $listnodesfunc,
+    "failover-mechanism" );
 
-  if (defined $failover_mechanism[0] && $failover_mechanism[0] eq 'vrrp') {
-    $failover_sync_grp = Vyatta::ConntrackSync::get_conntracksync_val(
-       $returnvalfunc,
-       "failover-mechanism $failover_mechanism[0] vrrp-sync-group" );
+  if ( defined $failover_mechanism[0] && $failover_mechanism[0] eq 'vrrp' ) {
+    $failover_sync_grp =
+      Vyatta::ConntrackSync::get_conntracksync_val( $returnvalfunc,
+      "failover-mechanism $failover_mechanism[0] vrrp-sync-group" );
   }
   return $failover_sync_grp;
 }
 
 sub keepalived_get_values {
-    my ($intf, $path) = @_;
-
-    my @errs   = ();
-    my $output = '';
-    my $config = new Vyatta::Config;
-
-    my $state_transition_script = get_state_script();
-    
-    vrrp_log("keepalived_get_values [$intf][$path]");
-    $config->setLevel("$path vrrp vrrp-group");
-    my @groups = $config->listNodes();
-    foreach my $group (@groups) {
-	my $vrrp_instance = "vyatta-$intf-$group";
-	$config->setLevel("$path vrrp vrrp-group $group");
-	if ($config->exists("disable")) {
-	    vrrp_log("$vrrp_instance disabled - skipping");
-	    my $state_file = get_state_file($intf, $group);
-	    system("rm -f $state_file");
-	    next;
-	}
-	my @vips = $config->returnValues("virtual-address");
-	my $num_vips = scalar(@vips);
-	if ($num_vips == 0) {
-	    push @errs, "must define a virtual-address for vrrp-group $group\n";
-	    next;
-	}
-	if ($num_vips > 20) {
-	    push @errs, "can not set more than 20 VIPs per group\n";
-	    next
-	}
-	my $priority = $config->returnValue("priority");
-	if (!defined $priority) {
-	    $priority = 1;
-	}
-	my $preempt = $config->returnValue("preempt");
-	if (!defined $preempt) {
-	    $preempt = "true";
-	}
-	my $preempt_delay = $config->returnValue("preempt-delay");
-	if (defined $preempt_delay and $preempt eq "false") {
-	    print "Warning: preempt delay is ignored when preempt=false\n";
-	}
-	my $advert_int = $config->returnValue("advertise-interval");
-	if (!defined $advert_int) {
-	    $advert_int = 1;
-	}
-	my $sync_group = $config->returnValue("sync-group");
-	if (defined $sync_group && $sync_group ne "") {
-	    push @{ $HoA_sync_groups{$sync_group} }, $vrrp_instance;
-	}
-	my $hello_source_addr = $config->returnValue("hello-source-address");
-	my $err = validate_source_addr($intf, $hello_source_addr);
-	if (defined $err) {
-	    push @errs, $err;
-	    next;
-	}
-
-	$config->setLevel("$path vrrp vrrp-group $group authentication");
-	my $auth_type = $config->returnValue("type");
-	my $auth_pass;
-	if (defined $auth_type) {
-	    $auth_type = "PASS" if $auth_type eq "simple";
-	    $auth_type = uc($auth_type);
-	    $auth_pass = $config->returnValue("password");
-	    if (! defined $auth_pass) {
-		push @errs, "vrrp authentication password not set\n";
-		next;
-	    }
-	}
-
-	$config->setLevel("$path vrrp vrrp-group $group run-transition-scripts");
-        my $run_backup_script = $config->returnValue("backup");
-        if(!defined $run_backup_script){
-           $run_backup_script = "null";
-        }
-        my $run_fault_script = $config->returnValue("fault");
-        if(!defined $run_fault_script){
-           $run_fault_script = "null";
-        }
-        my $run_master_script = $config->returnValue("master");
-        if(!defined $run_master_script){
-           $run_master_script = "null";
-        }
+  my ( $intf, $path ) = @_;
+
+  my @errs   = ();
+  my $output = '';
+  my $config = new Vyatta::Config;
+
+  my $state_transition_script = get_state_script();
+
+  vrrp_log("keepalived_get_values [$intf][$path]");
+  $config->setLevel("$path vrrp vrrp-group");
+  my @groups = $config->listNodes();
+  foreach my $group (@groups) {
+    my $vrrp_instance = "vyatta-$intf-$group";
+    $config->setLevel("$path vrrp vrrp-group $group");
+    if ( $config->exists("disable") ) {
+      vrrp_log("$vrrp_instance disabled - skipping");
+      my $state_file = get_state_file( $intf, $group );
+      system("rm -f $state_file");
+      next;
+    }
+    my @vips     = $config->returnValues("virtual-address");
+    my $num_vips = scalar(@vips);
+    if ( $num_vips == 0 ) {
+      push @errs, "must define a virtual-address for vrrp-group $group\n";
+      next;
+    }
+    if ( $num_vips > 20 ) {
+      push @errs, "can not set more than 20 VIPs per group\n";
+      next;
+    }
+    my $priority = $config->returnValue("priority");
+    if ( !defined $priority ) {
+      $priority = 1;
+    }
+    my $preempt = $config->returnValue("preempt");
+    if ( !defined $preempt ) {
+      $preempt = "true";
+    }
+    my $preempt_delay = $config->returnValue("preempt-delay");
+    if ( defined $preempt_delay and $preempt eq "false" ) {
+      print "Warning: preempt delay is ignored when preempt=false\n";
+    }
+    my $advert_int = $config->returnValue("advertise-interval");
+    if ( !defined $advert_int ) {
+      $advert_int = 1;
+    }
+    my $sync_group = $config->returnValue("sync-group");
+    if ( defined $sync_group && $sync_group ne "" ) {
+      push @{ $HoA_sync_groups{$sync_group} }, $vrrp_instance;
+    }
+    my $hello_source_addr = $config->returnValue("hello-source-address");
+    my $err = validate_source_addr( $intf, $hello_source_addr );
+    if ( defined $err ) {
+      push @errs, $err;
+      next;
+    }
 
-	# We now have the values and have validated them, so 
-	# generate the config.
-
-	$output  .= "vrrp_instance $vrrp_instance \{\n";
-	my $init_state;
-	if (defined $ctsync) {
-	  # check if this group is part of conntrack-sync vrrp-sync-group
-	  my $ctsync_syncgrp = get_ctsync_syncgrp();
-	  my $vrrpsyncgrp = list_vrrp_sync_group($intf, $group, 'returnOrigPlusComValue');
-	  if (	defined $ctsync_syncgrp && 
-		defined $vrrpsyncgrp && 
-		($ctsync_syncgrp eq $vrrpsyncgrp)
-	     ) {
-	    	$init_state = 'BACKUP';
-          } else {
-            $init_state = vrrp_get_init_state($intf, $group, $vips[0], $preempt);
-          }
-	} else {
-	  $init_state = vrrp_get_init_state($intf, $group, $vips[0], $preempt);
-	}
-	$output .= "\tstate $init_state\n";
-	$output .= "\tinterface $intf\n";
-	$output .= "\tvirtual_router_id $group\n";
-	$output .= "\tpriority $priority\n";
-	if ($preempt eq "false") {
-	    $output .= "\tnopreempt\n";
-	}
-	if (defined $preempt_delay) {
-	    $output .= "\tpreempt_delay $preempt_delay\n";
-	}
-	$output .= "\tadvert_int $advert_int\n";
-	if (defined $auth_type) {
-	    $output .= "\tauthentication {\n";
-	    $output .= "\t\tauth_type $auth_type\n";
-	    $output .= "\t\tauth_pass $auth_pass\n\t}\n";
-	}
-	if (defined $hello_source_addr) {
-	    $output .= "\tmcast_src_ip $hello_source_addr\n";
-	}
-	$output .= "\tvirtual_ipaddress \{\n";
-	foreach my $vip (@vips) {
-	    $output .= "\t\t$vip\n";
-	}
-	$output .= "\t\}\n";
-	$output .= "\tnotify_master \"$state_transition_script master ";
-	$output .=     "$intf $group $run_master_script @vips\" \n";
-	$output .= "\tnotify_backup \"$state_transition_script backup ";
-        $output .=     "$intf $group $run_backup_script @vips\" \n";
-	$output .= "\tnotify_fault \"$state_transition_script fault ";
-	$output .=     "$intf $group $run_fault_script @vips\" \n";
-	$output .= "\}\n\n";
+    $config->setLevel("$path vrrp vrrp-group $group authentication");
+    my $auth_type = $config->returnValue("type");
+    my $auth_pass;
+    if ( defined $auth_type ) {
+      $auth_type = "PASS" if $auth_type eq "simple";
+      $auth_type = uc($auth_type);
+      $auth_pass = $config->returnValue("password");
+      if ( !defined $auth_pass ) {
+        push @errs, "vrrp authentication password not set\n";
+        next;
+      }
     }
 
-    return ($output, @errs);
+    $config->setLevel("$path vrrp vrrp-group $group run-transition-scripts");
+    my $run_backup_script = $config->returnValue("backup");
+    if ( !defined $run_backup_script ) {
+      $run_backup_script = "null";
+    }
+    my $run_fault_script = $config->returnValue("fault");
+    if ( !defined $run_fault_script ) {
+      $run_fault_script = "null";
+    }
+    my $run_master_script = $config->returnValue("master");
+    if ( !defined $run_master_script ) {
+      $run_master_script = "null";
+    }
+
+    # We now have the values and have validated them, so
+    # generate the config.
+
+    $output .= "vrrp_instance $vrrp_instance \{\n";
+    my $init_state;
+    if ( defined $ctsync ) {
+
+      # check if this group is part of conntrack-sync vrrp-sync-group
+      my $ctsync_syncgrp = get_ctsync_syncgrp();
+      my $vrrpsyncgrp =
+        list_vrrp_sync_group( $intf, $group, 'returnOrigPlusComValue' );
+      if ( defined $ctsync_syncgrp
+        && defined $vrrpsyncgrp
+        && ( $ctsync_syncgrp eq $vrrpsyncgrp ) )
+      {
+        $init_state = 'BACKUP';
+      } else {
+        $init_state = vrrp_get_init_state( $intf, $group, $vips[0], $preempt );
+      }
+    } else {
+      $init_state = vrrp_get_init_state( $intf, $group, $vips[0], $preempt );
+    }
+    $output .= "\tstate $init_state\n";
+    $output .= "\tinterface $intf\n";
+    $output .= "\tvirtual_router_id $group\n";
+    $output .= "\tpriority $priority\n";
+    if ( $preempt eq "false" ) {
+      $output .= "\tnopreempt\n";
+    }
+    if ( defined $preempt_delay ) {
+      $output .= "\tpreempt_delay $preempt_delay\n";
+    }
+    $output .= "\tadvert_int $advert_int\n";
+    if ( defined $auth_type ) {
+      $output .= "\tauthentication {\n";
+      $output .= "\t\tauth_type $auth_type\n";
+      $output .= "\t\tauth_pass $auth_pass\n\t}\n";
+    }
+    if ( defined $hello_source_addr ) {
+      $output .= "\tmcast_src_ip $hello_source_addr\n";
+    }
+    $output .= "\tvirtual_ipaddress \{\n";
+    foreach my $vip (@vips) {
+      $output .= "\t\t$vip\n";
+    }
+    $output .= "\t\}\n";
+    $output .= "\tnotify_master \"$state_transition_script master ";
+    $output .= "$intf $group $run_master_script @vips\" \n";
+    $output .= "\tnotify_backup \"$state_transition_script backup ";
+    $output .= "$intf $group $run_backup_script @vips\" \n";
+    $output .= "\tnotify_fault \"$state_transition_script fault ";
+    $output .= "$intf $group $run_fault_script @vips\" \n";
+    $output .= "\}\n\n";
+  }
+
+  return ( $output, @errs );
 }
 
 sub vrrp_get_sync_groups {
-    
-    my $output = "";
-   
-    foreach my $sync_group ( keys %HoA_sync_groups) {
-	$output .= "vrrp_sync_group $sync_group \{\n\tgroup \{\n";
-	foreach my $vrrp_instance ( 0 .. $#{ $HoA_sync_groups{$sync_group} } ) {
-		$output .= "\t\t$HoA_sync_groups{$sync_group}[$vrrp_instance]\n";
-	}
-	$output .= "\t\}\n";
-	
-	## add conntrack-sync part here if configured ##
-	my $origfunc = undef;
-	$origfunc = 'true' if ! defined $ctsync;
-	my $failover_sync_grp = get_ctsync_syncgrp($origfunc);
-	if (defined $failover_sync_grp && $failover_sync_grp eq $sync_group) {
-		$output .= "\tnotify_master \"$ctsync_script master $sync_group\"\n";
-	    	$output .= "\tnotify_backup \"$ctsync_script backup $sync_group\"\n";
-	    	$output .= "\tnotify_fault \"$ctsync_script fault $sync_group\"\n";
-	}
-	$output .= "\}\n";
+
+  my $output = "";
+
+  foreach my $sync_group ( keys %HoA_sync_groups ) {
+    $output .= "vrrp_sync_group $sync_group \{\n\tgroup \{\n";
+    foreach my $vrrp_instance ( 0 .. $#{ $HoA_sync_groups{$sync_group} } ) {
+      $output .= "\t\t$HoA_sync_groups{$sync_group}[$vrrp_instance]\n";
+    }
+    $output .= "\t\}\n";
+
+    ## add conntrack-sync part here if configured ##
+    my $origfunc = undef;
+    $origfunc = 'true' if !defined $ctsync;
+    my $failover_sync_grp = get_ctsync_syncgrp($origfunc);
+    if ( defined $failover_sync_grp && $failover_sync_grp eq $sync_group ) {
+      $output .= "\tnotify_master \"$ctsync_script master $sync_group\"\n";
+      $output .= "\tnotify_backup \"$ctsync_script backup $sync_group\"\n";
+      $output .= "\tnotify_fault \"$ctsync_script fault $sync_group\"\n";
     }
-    return $output;
+    $output .= "\}\n";
+  }
+  return $output;
 }
 
 sub vrrp_read_changes {
-    my @lines = ();
-    return @lines if ! -e $changes_file;
-    open(my $FILE, "<", $changes_file) or die "Error: read $!";
-    @lines = <$FILE>;
-    close($FILE);
-    chomp @lines;
-    return @lines;
+  my @lines = ();
+  return @lines if !-e $changes_file;
+  open( my $FILE, "<", $changes_file ) or die "Error: read $!";
+  @lines = <$FILE>;
+  close($FILE);
+  chomp @lines;
+  return @lines;
 }
 
 sub vrrp_save_changes {
-    my @list = @_;
+  my @list = @_;
 
-    my $num_changes = scalar(@list);
-    vrrp_log("saving changes file $num_changes");
-    open(my $FILE, ">", $changes_file) or die "Error: write $!";
-    print $FILE join("\n", @list), "\n";
-    close($FILE);
+  my $num_changes = scalar(@list);
+  vrrp_log("saving changes file $num_changes");
+  open( my $FILE, ">", $changes_file ) or die "Error: write $!";
+  print $FILE join( "\n", @list ), "\n";
+  close($FILE);
 }
 
 sub vrrp_find_changes {
 
-    my @list = ();
-    my $config = new Vyatta::Config;
-    my $vrrp_instances = 0;
-
-    foreach my $name ( getInterfaces() ) {
-	my $intf = new Vyatta::Interface($name);
-        next unless $intf;
-	my $path = $intf->path();
-	$config->setLevel($path);
-	if ($config->exists("vrrp")) {
-	    my %vrrp_status_hash = $config->listNodeStatus("vrrp");
-	    my ($vrrp, $vrrp_status) = each(%vrrp_status_hash);
-	    if ($vrrp_status ne "static") {
-		push @list, $name;
-		vrrp_log("$vrrp_status found $name");
-	    }
-	}
-
-	#
-	# Now look for deleted from the origin tree
-	#
-	$config->setLevel($path);
-	if ($config->isDeleted("vrrp")) {
-	    push @list, $name;
-	    vrrp_log("Delete found $name");
-	}
-
-
+  my @list           = ();
+  my $config         = new Vyatta::Config;
+  my $vrrp_instances = 0;
+
+  foreach my $name ( getInterfaces() ) {
+    my $intf = new Vyatta::Interface($name);
+    next unless $intf;
+    my $path = $intf->path();
+    $config->setLevel($path);
+    if ( $config->exists("vrrp") ) {
+      my %vrrp_status_hash = $config->listNodeStatus("vrrp");
+      my ( $vrrp, $vrrp_status ) = each(%vrrp_status_hash);
+      if ( $vrrp_status ne "static" ) {
+        push @list, $name;
+        vrrp_log("$vrrp_status found $name");
+      }
     }
 
-    my $num = scalar(@list);
-    vrrp_log("Start transation: $num changes");
-    if ($num) {
-	vrrp_save_changes(@list);
+    #
+    # Now look for deleted from the origin tree
+    #
+    $config->setLevel($path);
+    if ( $config->isDeleted("vrrp") ) {
+      push @list, $name;
+      vrrp_log("Delete found $name");
     }
-    return $num;
+
+  }
+
+  my $num = scalar(@list);
+  vrrp_log("Start transation: $num changes");
+  if ($num) {
+    vrrp_save_changes(@list);
+  }
+  return $num;
 }
 
 sub remove_from_changes {
-    my $intf = shift;
-
-    my @lines = vrrp_read_changes();
-    if (scalar(@lines) < 1) {
-	#
-	# we shouldn't get to this point, but try to handle it if we do
-	#
-	vrrp_log("unexpected remove_from_changes()");
-	system("rm -f $changes_file");
-	return 0;
-    }
-    my @new_lines = ();
-    foreach my $line (@lines) {
-	if ($line =~ /$intf$/) {
-	    vrrp_log("remove_from_changes [$line]");
-	} else {
-	    push @new_lines, $line;
-	}
-    }
+  my $intf = shift;
+
+  my @lines = vrrp_read_changes();
+  if ( scalar(@lines) < 1 ) {
 
-    my $num_changes = scalar(@new_lines);
-    if ($num_changes > 0) {
-	vrrp_save_changes(@new_lines);
+    #
+    # we shouldn't get to this point, but try to handle it if we do
+    #
+    vrrp_log("unexpected remove_from_changes()");
+    system("rm -f $changes_file");
+    return 0;
+  }
+  my @new_lines = ();
+  foreach my $line (@lines) {
+    if ( $line =~ /$intf$/ ) {
+      vrrp_log("remove_from_changes [$line]");
     } else {
-	system("rm -f $changes_file");
+      push @new_lines, $line;
     }
-    return $num_changes;
+  }
+
+  my $num_changes = scalar(@new_lines);
+  if ( $num_changes > 0 ) {
+    vrrp_save_changes(@new_lines);
+  } else {
+    system("rm -f $changes_file");
+  }
+  return $num_changes;
 }
 
 sub vrrp_update_config {
 
-    my @errs   = ();
-    my $date   = localtime();
-    my $output = "#\n# autogenerated by $0 on $date\n#\n\n";
-
-    my $config = new Vyatta::Config;
-    my $vrrp_instances = 0;
-
-    foreach my $name ( getInterfaces() ) {
-	my $intf = new Vyatta::Interface($name);
-        next unless $intf;
-	my $path = $intf->path();
-	$config->setLevel($path);
-	if ($config->exists("vrrp")) {
-	    #
-	    # keepalived gets real grumpy with interfaces that
-	    # don't exist, so skip vlans that haven't been
-	    # instantiated yet (typically occurs at boot up).
-	    #
-	    if (!(-d "/sys/class/net/$name")) {
-		push @errs, "$name doesn't exist";
-		next;
-	    }
-	    my ($inst_output, @inst_errs) =
-		keepalived_get_values($name, $path);
-	    if (scalar(@inst_errs)) {
-		push @errs, @inst_errs;
-	    } else {
-		$output .= $inst_output;
-		$vrrp_instances++;
-	    }
-	}
+  my @errs   = ();
+  my $date   = localtime();
+  my $output = "#\n# autogenerated by $0 on $date\n#\n\n";
+
+  my $config         = new Vyatta::Config;
+  my $vrrp_instances = 0;
+
+  foreach my $name ( getInterfaces() ) {
+    my $intf = new Vyatta::Interface($name);
+    next unless $intf;
+    my $path = $intf->path();
+    $config->setLevel($path);
+    if ( $config->exists("vrrp") ) {
+
+      #
+      # keepalived gets real grumpy with interfaces that
+      # don't exist, so skip vlans that haven't been
+      # instantiated yet (typically occurs at boot up).
+      #
+      if ( !( -d "/sys/class/net/$name" ) ) {
+        push @errs, "$name doesn't exist";
+        next;
+      }
+      my ( $inst_output, @inst_errs ) = keepalived_get_values( $name, $path );
+      if ( scalar(@inst_errs) ) {
+        push @errs, @inst_errs;
+      } else {
+        $output .= $inst_output;
+        $vrrp_instances++;
+      }
+    }
+  }
+
+  if ( $vrrp_instances > 0 ) {
+    my $sync_groups = vrrp_get_sync_groups();
+    if ( defined $sync_groups && $sync_groups ne "" ) {
+      $output = $sync_groups . $output;
     }
-      
-    if ($vrrp_instances > 0) {
-	my $sync_groups = vrrp_get_sync_groups();
-	if (defined $sync_groups && $sync_groups ne "") {
-	    $output = $sync_groups . $output;
-	}
-	keepalived_write_file($conf_file, $output);
-    } 
-    return ($vrrp_instances, @errs);
+    keepalived_write_file( $conf_file, $output );
+  }
+  return ( $vrrp_instances, @errs );
 }
 
 sub keepalived_write_file {
-    my ($file, $data) = @_;
+  my ( $file, $data ) = @_;
 
-    open(my $fh, '>', $file) || die "Couldn't open $file - $!";
-    print $fh $data;
-    close $fh;
+  open( my $fh, '>', $file ) || die "Couldn't open $file - $!";
+  print $fh $data;
+  close $fh;
 }
 
 #
 # main
 #
-GetOptions("vrrp-action=s" 	=> \$action,
-	   "intf=s"        	=> \$vrrp_intf,
-	   "group=s"       	=> \$vrrp_group,
-           "vip=s"		=> \$vrrp_vip,
-           "ctsync=s"	   	=> \$ctsync,);
-
-if (! defined $action) {
-    print "no action\n";
-    exit 1;
+GetOptions(
+  "vrrp-action=s" => \$action,
+  "intf=s"        => \$vrrp_intf,
+  "group=s"       => \$vrrp_group,
+  "vip=s"         => \$vrrp_vip,
+  "ctsync=s"      => \$ctsync,
+);
+
+if ( !defined $action ) {
+  print "no action\n";
+  exit 1;
 }
 
-if (! defined $ctsync) {
+if ( !defined $ctsync ) {
+
   # make sure sync-group used by ctsync has not been deleted
 
   my $failover_sync_grp = get_ctsync_syncgrp();
-  if (defined $failover_sync_grp) {
+  if ( defined $failover_sync_grp ) {
+
     # make sure vrrp-sync-group exists
     my $sync_grp_exists = 'false';
-    my @vrrp_intfs = list_vrrp_intf('exists');
+    my @vrrp_intfs      = list_vrrp_intf('exists');
     foreach my $vrrp_intf (@vrrp_intfs) {
-      my @vrrp_groups = list_vrrp_group($vrrp_intf, 'listNodes');
+      my @vrrp_groups = list_vrrp_group( $vrrp_intf, 'listNodes' );
       foreach my $vrrp_group (@vrrp_groups) {
-        my $sync_grp = list_vrrp_sync_group($vrrp_intf, $vrrp_group, 'returnValue');
-        if (defined $sync_grp && $sync_grp eq "$failover_sync_grp") {
+        my $sync_grp =
+          list_vrrp_sync_group( $vrrp_intf, $vrrp_group, 'returnValue' );
+        if ( defined $sync_grp && $sync_grp eq "$failover_sync_grp" ) {
           $sync_grp_exists = 'true';
           last;
         }
@@ -436,88 +445,89 @@ if (! defined $ctsync) {
       last if $sync_grp_exists eq 'true';
     }
 
-    if ($sync_grp_exists eq 'false') {
-      print 	"sync-group $failover_sync_grp used for conntrack-sync" . 
-		" is either deleted or undefined\n";
+    if ( $sync_grp_exists eq 'false' ) {
+      print "sync-group $failover_sync_grp used for conntrack-sync"
+        . " is either deleted or undefined\n";
       exit 1;
-    } 
+    }
   }
 
 }
 
-if ($action eq "update") {
-    $changes_file = get_changes_file();
-    $conf_file    = get_conf_file();
-    vrrp_log("vrrp update $vrrp_intf") if defined $vrrp_intf;
-    vrrp_log("vrrp update conntrack-sync") if defined $ctsync;
-    if ( ! -e $changes_file) {
-	my $num_changes = vrrp_find_changes();
-	if ($num_changes == 0) {
-	    #
-	    # Shouldn't happen, but ...
-	    #
-	    vrrp_log("unexpected 0 changes");
-	}
-    }
-    my ($vrrp_instances, @errs) = vrrp_update_config();
-    my $more_changes = 0;
-    $more_changes = remove_from_changes($vrrp_intf) if ! defined $ctsync;
-    vrrp_log(" instances $vrrp_instances, $more_changes");
-    if ($vrrp_instances > 0 and $more_changes == 0) {
-	restart_daemon($conf_file);
-    } 
-    if ($vrrp_instances == 0) {
-	stop_daemon();
-	system("rm -f $conf_file");
-    }
-    if (scalar(@errs)) {
-	print join("\n", @errs);
-	vrrp_log(join("\n", @errs));
-	exit 1
+if ( $action eq "update" ) {
+  $changes_file = get_changes_file();
+  $conf_file    = get_conf_file();
+  vrrp_log("vrrp update $vrrp_intf")     if defined $vrrp_intf;
+  vrrp_log("vrrp update conntrack-sync") if defined $ctsync;
+  if ( !-e $changes_file ) {
+    my $num_changes = vrrp_find_changes();
+    if ( $num_changes == 0 ) {
+
+      #
+      # Shouldn't happen, but ...
+      #
+      vrrp_log("unexpected 0 changes");
     }
-    exit 0;
+  }
+  my ( $vrrp_instances, @errs ) = vrrp_update_config();
+  my $more_changes = 0;
+  $more_changes = remove_from_changes($vrrp_intf) if !defined $ctsync;
+  vrrp_log(" instances $vrrp_instances, $more_changes");
+  if ( $vrrp_instances > 0 and $more_changes == 0 ) {
+    restart_daemon($conf_file);
+  }
+  if ( $vrrp_instances == 0 ) {
+    stop_daemon();
+    system("rm -f $conf_file");
+  }
+  if ( scalar(@errs) ) {
+    print join( "\n", @errs );
+    vrrp_log( join( "\n", @errs ) );
+    exit 1;
+  }
+  exit 0;
 }
 
-if ($action eq "delete") {
-    if (! defined $vrrp_intf || ! defined $vrrp_group) {
-	print "must include interface & group";
-	exit 1;
-    }
-    vrrp_log("vrrp delete $vrrp_intf $vrrp_group");
-    my $state_file = get_state_file($vrrp_intf, $vrrp_group);
-    system("rm -f $state_file");
-    exit 0;
+if ( $action eq "delete" ) {
+  if ( !defined $vrrp_intf || !defined $vrrp_group ) {
+    print "must include interface & group";
+    exit 1;
+  }
+  vrrp_log("vrrp delete $vrrp_intf $vrrp_group");
+  my $state_file = get_state_file( $vrrp_intf, $vrrp_group );
+  system("rm -f $state_file");
+  exit 0;
 }
 
-if ($action eq "check-vip") {
-    if (! defined $vrrp_vip) {
-	print "must include the virtual-address to check";
-	exit 1;
-    }
-    my $rc = 1;
-    if ($vrrp_vip =~ /\//) {
-	$rc = Vyatta::TypeChecker::validateType('ipv4net', $vrrp_vip, 1);
-    } else {
-	$rc = Vyatta::TypeChecker::validateType('ipv4', $vrrp_vip, 1);
-    }
-    exit 1 if ! $rc;
-    exit 0;
+if ( $action eq "check-vip" ) {
+  if ( !defined $vrrp_vip ) {
+    print "must include the virtual-address to check";
+    exit 1;
+  }
+  my $rc = 1;
+  if ( $vrrp_vip =~ /\// ) {
+    $rc = Vyatta::TypeChecker::validateType( 'ipv4net', $vrrp_vip, 1 );
+  } else {
+    $rc = Vyatta::TypeChecker::validateType( 'ipv4', $vrrp_vip, 1 );
+  }
+  exit 1 if !$rc;
+  exit 0;
 }
 
-if ($action eq "list-vrrp-intf") {
-    my @intfs = list_vrrp_intf();
-    print join(' ', @intfs);
-    exit 0;
+if ( $action eq "list-vrrp-intf" ) {
+  my @intfs = list_vrrp_intf();
+  print join( ' ', @intfs );
+  exit 0;
 }
 
-if ($action eq "list-vrrp-group") {
-    if (! defined $vrrp_intf) {
-	print "must include interface\n";
-	exit 1;
-    }
-    my @groups = list_vrrp_group($vrrp_intf);
-    print join(' ', @groups);
-    exit 0;
+if ( $action eq "list-vrrp-group" ) {
+  if ( !defined $vrrp_intf ) {
+    print "must include interface\n";
+    exit 1;
+  }
+  my @groups = list_vrrp_group($vrrp_intf);
+  print join( ' ', @groups );
+  exit 0;
 }
 
 exit 0;