summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
Diffstat (limited to 'scripts')
-rw-r--r--scripts/dynamic-dns/vyatta-dynamic-dns.pl4
-rwxr-xr-xscripts/system/vyatta_update_login.pl6
2 files changed, 5 insertions, 5 deletions
diff --git a/scripts/dynamic-dns/vyatta-dynamic-dns.pl b/scripts/dynamic-dns/vyatta-dynamic-dns.pl
index 1d8511c5..232d260e 100644
--- a/scripts/dynamic-dns/vyatta-dynamic-dns.pl
+++ b/scripts/dynamic-dns/vyatta-dynamic-dns.pl
@@ -126,10 +126,8 @@ sub dynamicdns_get_values {
my @hostnames = $config->returnValues("host-name");
my $server = $config->returnValue("server");
foreach my $hostname (@hostnames) {
+ $output .= "server=$server," if defined $server;
$output .= "protocol=$service\n";
- if (defined $server) {
- $output .= "server=$server\n";
- }
$output .= "max-interval=28d\n";
$output .= "login=$login\n";
$output .= "password='$password'\n";
diff --git a/scripts/system/vyatta_update_login.pl b/scripts/system/vyatta_update_login.pl
index d482c297..c8d0a23a 100755
--- a/scripts/system/vyatta_update_login.pl
+++ b/scripts/system/vyatta_update_login.pl
@@ -120,8 +120,10 @@ for my $user (@user_keys) {
$cmd .= " -c \"$fname\"" if ( defined $fname );
$cmd .= " -d \"$home\"" if ( defined $home );
$cmd .= ' -G ' . join( ',', @groups );
- system("sudo $cmd $user") == 0
- or die "sudo $cmd $user failed: $?";
+ system("sudo $cmd $user");
+ return if ($? == 0);
+ my $reason = $reasons{($? >> 8)};
+ die "Attempt to change user $user failed: $reason\n";
}
}