From 78681dc9134ae490fb67ba1fd1f627114fcdc0b5 Mon Sep 17 00:00:00 2001
From: Robert Bays <robert@vyatta.com>
Date: Thu, 12 Aug 2010 18:27:40 -0700
Subject: fix for bug 6034

---
 lib/Vyatta/Quagga/Config.pm | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

(limited to 'lib/Vyatta/Quagga/Config.pm')

diff --git a/lib/Vyatta/Quagga/Config.pm b/lib/Vyatta/Quagga/Config.pm
index bf45c891..a24838f1 100644
--- a/lib/Vyatta/Quagga/Config.pm
+++ b/lib/Vyatta/Quagga/Config.pm
@@ -342,9 +342,8 @@ sub _qtree {
 
   $qcom = $_qcomref;
   
-  # It's ugly that I have to create a new Vyatta config object every time,
-  # but something gets messed up on the stack if I don't.  not sure
-  # what yet.  would love to reference a global config and just reset Level.
+  # Would love to reference a global config and just reset Levels,
+  # but Vyatta::Config isn't recursion safe.
   my $config = new Vyatta::Config;
   $config->setLevel($level);
 
@@ -356,7 +355,28 @@ sub _qtree {
   else {
     $vtysh = \%_vtyshdel;
     @nodes = $config->listDeleted();
-  }
+
+    # handle special case for multi-nodes values being deleted
+    # listDeleted() doesn't return the node as deleted if it is a multi
+    # unless all values are deleted.
+    # TODO: fix listDeleted() in Config.pm
+    # This is really, really fugly.
+    my @all_nodes = $config->listNodes();
+    foreach my $node (@all_nodes) {
+      my @array = split /\s+/, $level;
+      push @array, $node;
+      my ($multi, $text, $default) = $config->parseTmpl(\@array);
+      if ($multi) {
+        my @orig_values = $config->returnOrigValues("$node");
+        my @new_values = $config->returnValues("$node");
+        my %chash = $config->compareValueLists(\@orig_values, \@new_values);
+        if ($chash{'deleted'}) {                 
+          push @nodes, $node;
+        }
+      }
+    }
+
+  } ## end else {
 
   if ($_DEBUG) { print "DEBUG: _qtree - action: $action\tlevel: $level\n"; }
 
-- 
cgit v1.2.3


From ea4cc868c80dcc16dd50d199cd4b761d0c4a6a74 Mon Sep 17 00:00:00 2001
From: Robert Bays <robert@vyatta.com>
Date: Mon, 16 Aug 2010 11:49:51 -0700
Subject: fix for bug 6054

---
 lib/Vyatta/Quagga/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'lib/Vyatta/Quagga/Config.pm')

diff --git a/lib/Vyatta/Quagga/Config.pm b/lib/Vyatta/Quagga/Config.pm
index a24838f1..90a3d4d0 100644
--- a/lib/Vyatta/Quagga/Config.pm
+++ b/lib/Vyatta/Quagga/Config.pm
@@ -370,7 +370,7 @@ sub _qtree {
         my @orig_values = $config->returnOrigValues("$node");
         my @new_values = $config->returnValues("$node");
         my %chash = $config->compareValueLists(\@orig_values, \@new_values);
-        if ($chash{'deleted'}) {                 
+        if (${$chash{'deleted'}}[0]) {                 
           push @nodes, $node;
         }
       }
-- 
cgit v1.2.3