summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Breunig <christian@breunig.cc>2023-04-03 08:02:24 +0200
committerChristian Breunig <christian@breunig.cc>2023-04-03 08:02:24 +0200
commit964e06bc3404b096d55e939b2bdb8d9c61a6a9b9 (patch)
tree6a43b955c90dad0b82a594918c0ee5fab97b1c7b
parentf34e9028252034cf17dbf380a2cded8bf14c71c2 (diff)
downloadvyatta-cfg-system-964e06bc3404b096d55e939b2bdb8d9c61a6a9b9.tar.gz
vyatta-cfg-system-964e06bc3404b096d55e939b2bdb8d9c61a6a9b9.zip
T5136: do not rm -rf if unmount fails
Commit f34e9028 ("T5136: properly unmount filesystems after installation") assumed it would be a good idea to simply rm -rf the new root folder. This could have a bad, non booting side effect. Warn user if unmount fails but the filesystem is synced anyway. The rest is handled by the Kernel on reboot.
-rwxr-xr-xscripts/install/install-image-existing1
1 files changed, 0 insertions, 1 deletions
diff --git a/scripts/install/install-image-existing b/scripts/install/install-image-existing
index abbd1421..feba6683 100755
--- a/scripts/install/install-image-existing
+++ b/scripts/install/install-image-existing
@@ -280,7 +280,6 @@ fi
# unmount filesystems
if ! try_unmount "--read-only $INST_ROOT $READ_ROOT"; then
- rm -rf $REL_ROOT
failure_exit 'Failed to unmount new squashfs image.'
fi