summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Hendry <jhendry@mintel.com>2014-10-29 17:50:59 +0000
committerDaniil Baturin <daniil@baturin.org>2017-09-14 13:37:06 +0200
commit4b00dd03890d7c378b1c53f0a9edc26e3fcc9102 (patch)
tree8cf9d5ef2bb6366ce5a485f03aa2d2a850e5bfc3
parentc9efbb8b26c59b36a4d69716afa8ec2e016b572e (diff)
downloadvyatta-cfg-system-4b00dd03890d7c378b1c53f0a9edc26e3fcc9102.tar.gz
vyatta-cfg-system-4b00dd03890d7c378b1c53f0a9edc26e3fcc9102.zip
Cleaning up ethtool execution code
-rwxr-xr-xscripts/vyatta-interfaces.pl6
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/vyatta-interfaces.pl b/scripts/vyatta-interfaces.pl
index 14f0a125..9271e871 100755
--- a/scripts/vyatta-interfaces.pl
+++ b/scripts/vyatta-interfaces.pl
@@ -603,15 +603,15 @@ sub set_offload_setting {
'udp-segmentation-offload' => 'ufo',
);
- $args = "$ethtool_opts{$option} $nvalue" if (defined($nvalue) && $nvalue ne $ovalue);
+ if (defined($nvalue) && $nvalue ne $ovalue) {
- if ($args ne '') {
- my $cmd = "$ETHTOOL -K $intf $args";
+ my $cmd = "$ETHTOOL -K $intf $ethtool_opts{$option} $nvalue";
system($cmd);
if ($? >> 8) {
die "exec of $ETHTOOL failed: '$cmd'";
}
}
+
}