From c146c4433d10af8a46973b242d48c2aee920dff8 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 May 2009 13:53:29 -0700 Subject: Print error message on failure to create group/user Bug 4448 --- scripts/system/vyatta_update_login.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'scripts') diff --git a/scripts/system/vyatta_update_login.pl b/scripts/system/vyatta_update_login.pl index d482c297..c8d0a23a 100755 --- a/scripts/system/vyatta_update_login.pl +++ b/scripts/system/vyatta_update_login.pl @@ -120,8 +120,10 @@ for my $user (@user_keys) { $cmd .= " -c \"$fname\"" if ( defined $fname ); $cmd .= " -d \"$home\"" if ( defined $home ); $cmd .= ' -G ' . join( ',', @groups ); - system("sudo $cmd $user") == 0 - or die "sudo $cmd $user failed: $?"; + system("sudo $cmd $user"); + return if ($? == 0); + my $reason = $reasons{($? >> 8)}; + die "Attempt to change user $user failed: $reason\n"; } } -- cgit v1.2.3 From c265b75d1b5bf6a317a99bd99a4c49c5f2c6a8b3 Mon Sep 17 00:00:00 2001 From: Mohit Mehta Date: Fri, 29 May 2009 11:28:53 -0700 Subject: move server,protocol to the same line in config file --- scripts/dynamic-dns/vyatta-dynamic-dns.pl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'scripts') diff --git a/scripts/dynamic-dns/vyatta-dynamic-dns.pl b/scripts/dynamic-dns/vyatta-dynamic-dns.pl index 1d8511c5..232d260e 100644 --- a/scripts/dynamic-dns/vyatta-dynamic-dns.pl +++ b/scripts/dynamic-dns/vyatta-dynamic-dns.pl @@ -126,10 +126,8 @@ sub dynamicdns_get_values { my @hostnames = $config->returnValues("host-name"); my $server = $config->returnValue("server"); foreach my $hostname (@hostnames) { + $output .= "server=$server," if defined $server; $output .= "protocol=$service\n"; - if (defined $server) { - $output .= "server=$server\n"; - } $output .= "max-interval=28d\n"; $output .= "login=$login\n"; $output .= "password='$password'\n"; -- cgit v1.2.3