From ecc62d95b95fd802dec09a3e0707eb536bf26960 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 5 Apr 2010 22:07:22 -0700 Subject: Use 3 arg open This fixes perlcritic warning because of using 2 arg open. The other form puts pipe as method. --- scripts/vyatta-interfaces.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scripts') diff --git a/scripts/vyatta-interfaces.pl b/scripts/vyatta-interfaces.pl index cbb6abf6..90a4e0f9 100755 --- a/scripts/vyatta-interfaces.pl +++ b/scripts/vyatta-interfaces.pl @@ -544,7 +544,7 @@ sub show_config_path { sub get_ethtool { my $dev = shift; - open( my $ethtool, "sudo /usr/sbin/ethtool $dev 2>/dev/null |" ) + open( my $ethtool, "-|", "sudo /usr/sbin/ethtool $dev 2>/dev/null" ) or die "ethtool failed: $!\n"; # ethtool produces: -- cgit v1.2.3