summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Gilligan <gilligan@vyatta.com>2009-05-21 17:22:58 -0700
committerBob Gilligan <gilligan@vyatta.com>2009-05-21 17:22:58 -0700
commitd1cb1b31135fda65d9a89fc61ce31249146f53c0 (patch)
tree9e654b4c79539eb2edcd9f505e25821c5b8e7920
parent613b7e3b36684e92cb7765b03bb4706a6caed98b (diff)
downloadvyatta-cfg-d1cb1b31135fda65d9a89fc61ce31249146f53c0.tar.gz
vyatta-cfg-d1cb1b31135fda65d9a89fc61ce31249146f53c0.zip
Bugfix 4432: Don't validate interface name in "check" sub-command.
The "check" sub-command is called by the CLI at "set" time. The interface may not be configured, or may be configured but not "up" at this time. So we don't want to perform any validation on the interface.
-rwxr-xr-xscripts/vyatta-irqaffin11
1 files changed, 6 insertions, 5 deletions
diff --git a/scripts/vyatta-irqaffin b/scripts/vyatta-irqaffin
index 1286130..a6b7b22 100755
--- a/scripts/vyatta-irqaffin
+++ b/scripts/vyatta-irqaffin
@@ -20,7 +20,7 @@
# **** End License ****
# Provides sub-commands to:
-# - Check the validity of an interface name and affinity mask value
+# - Check the validity of an affinity mask value
# - Set the affinity mask to the IRQs being used by an interface
# - Reset the affinity mask of the IRQs being used by an interface to the
# system default value of all-ones.
@@ -113,6 +113,11 @@ check_uniproc()
case "$1" in
check)
+ # Note: We don't validate the interface name even though
+ # it is available as a command argument. That is because
+ # the interface may not exist or may not be configured at
+ # the time the check is performed.
+ #
if [ $# -ne 3 ]; then
print_usage
exit 1
@@ -122,10 +127,6 @@ case "$1" in
exit 1
fi
- if ! get_irqnums $2 ; then
- exit 1
- fi
-
if ! get_mask $3 ; then
exit 1
fi