summaryrefslogtreecommitdiff
path: root/src/cli_new.c
AgeCommit message (Collapse)Author
2012-07-11Minor code cleanupStephen Hemminger
1. Make local functions static 2. Use C standard for function with no-args versus old K&R style 3. Make some arguments const
2012-07-11Don't leak file descriptors to actionStephen Hemminger
Bug 8204 Make sure we don't handle unnecessary file descriptors to child processes. This is done by marking file descriptors as close on exec, and closing pipe before exec.
2012-05-25Partial bugfix 8111John Southworth
This fixes the biggest memory leak in the config load. There are still a few small ones but they are not as big of a problem since the process is ephemeral.
2011-07-29Fix warning about unused function prototypeStephen Hemminger
2011-07-01Add another check for out_stream now all refrences are validated before ↵John Southworth
writing to it
2011-06-30Bugfix 7259: check that out_stream is not null before attempting to write to itJohn Southworth
2011-06-17Comment out unused functionsStephen Hemminger
2011-06-10Adjust the number of characters we print when creating an offset to the ↵John Southworth
buffer to remove the errloc tag
2011-06-09Bugfix 7153: Initialize buffer before reading into itJohn Southworth
2011-05-14close pipe fd before returningAn-Cheng Huang
2011-05-14minor changesAn-Cheng Huang
* remove warning. * make output more responsive.
2011-05-12fix for bug 6771An-Cheng Huang
* reimplement process management to fix breakage caused by commit 792d6aa0dd0ecfd45c9b5ab57c6c0cb71a9b8da6.
2011-05-10preliminary implementation of new commitAn-Cheng Huang
(cherry picked from commit 1b2a0fd1ae1e6dfc18e4f75f73cd7befb47cf538)
2011-02-28add config template abstractionAn-Cheng Huang
2011-02-22clean up dead code etc. etc. etc.An-Cheng Huang
2011-01-11use the old interface rather than call unlink directly.Michael Larson
(cherry picked from commit 3246881725b219e532464a0191d074e9f02cba23)
2011-01-11re-enable concurrent configuration commit locking.Michael Larson
locking can be overrode though commit -l flag. (cherry picked from commit c13f949c55df81052c73d394d5ed5ea18a65502b)
2011-01-04workaround for bug 5388An-Cheng Huang
* disallow double quote (") character in config values. (cherry picked from commit 143d9b4ed9fcf3ac29fd8bc8c6af6bb1921fada8)
2010-12-08need to check if process terminated normally before checking return code status.Michael Larson
2010-12-07Allow _errloc_ to be place on any line in output, not restricted to first line.Michael Larson
2010-12-06handle case for non-commit client with latest error location changes.Michael Larson
2010-12-02update to errloc. changed reader so that stderr/stdout is printed as it is ↵Michael Larson
received. Also added new -x option to commit to force messages to be printed via the old format.
2010-11-29add limit check on stdout capture (8192 characters).Michael Larson
2010-11-29fix for duplicate messages on some system commands.Michael Larson
2010-11-24implementation of err location support for commit process. commit failures ↵Michael Larson
will now look different (via cli): vyatta@vyatta# commit [ service nat ] NAT configuration error: rule type not specified/valid [ system domain-search domain ] System configuration error. Both 'domain-name' and 'domain-search' are specified, but only one of these mutually exclusive parameters is allowed. [ load-balancing wan ] WARNING: A valid WAN load-balance configuration requires an interface with a nexthop Commit failed Location of error will now be supplied on each failure, with the option to override the script node location.
2010-11-24use exit code 1 to ease init script usageAn-Cheng Huang
2010-11-12remove extra process layer--required before this command is expanded to ↵Michael Larson
handle other commit actions (i.e. ones that rely on consistent parent process id in scripts).
2010-07-28add cstore-specific header fileAn-Cheng Huang
2010-07-28add new cstore libraryAn-Cheng Huang
2010-07-21fix for bug 5882.Michael Larson
2010-07-19more cleanup to new help impl.Michael Larson
2010-07-19modified handling of status return codes for child process.Michael Larson
2010-07-19modified syntax and commit checks now applied during commit.Michael Larson
modification allows for error statement to be placed after location of error node.
2010-06-28return false for invalid value instead of exitingAn-Cheng Huang
2010-06-10add value character restrictionAn-Cheng Huang
* disallow newline in value strings. * move check into lib.
2010-06-08fix for bug 5667. Moved the location of the deactivate check.Michael Larson
2010-06-08fix for bug 5213An-Cheng Huang
* handle absolute variable references correctly.
2010-06-02simplify output initAn-Cheng Huang
2010-06-02Additional fix to cli_new.c on arg.Michael Larson
2010-06-02more fixes for compilier warnings.Michael Larson
2010-06-01bug fix for 5646. Suppress variable replacement if deactivated for disabled ↵Michael Larson
nodes (where variables reside).
2010-05-31fix for bug 5649. Need to initialize val_types for value comparison to ↵Michael Larson
ERROR_TYPE
2010-05-28fix bad comparison in multiple-type checkMichael Larson
2010-05-26fix for multiple type support in cli for the following case:Michael Larson
1) If multiple types are defined and one type is a submatch of the other type (i.e. ipv4 and ipv4net) 2) And one string is a submatch of the other (i.e. 3.3.3.3 and 3.3.3.3/32) 3) Then compare data types before comparing for value equality Fixes problem where the ipv4net wouldn't let the ipv4 value from being set if the ipv4 was a substring of the ipv4net.
2010-05-20fixed seg violation on commit due to extended multiple types support in ↵Michael Larson
valstruct.
2010-05-20fix for bug 5618. needed to extend valstruct to maintain multiple types ↵Michael Larson
rather than using first type found in node.val file. also simplified type check.
2010-04-15Multiple (i.e. one or two) datatypes can now be supported on a node.def type ↵Michael Larson
definition. type: ipv4,ipv6 Will now allow for the value to validated against both data types (or the first success). In the case of both failing the following message format will be returned: vyatta@vyatta# set load-balancing wan rule 1 "1" is not a valid value of type "bool" "1" is not a valid value of type "ipv4" Note, that any combination of types with text being one of the types is not supported. The reason being is that with text any value is allowed, therefore it doesn't really make sense to validate a datatype on text + ipv4 when text will always be successful.
2008-11-13Simplify the debug codeStephen Hemminger
dump_log doesn't need allocate whole buffer, just print in steps.
2008-10-28Fix 3505: cli crash on delete of ipv6net static route.Stig Thormodsrud
2008-09-04Fix build warningsStephen Hemminger
Get rid of warnings for push_path discards qualifiers from pointer target type.