From 6154dde83cd05e733275db68673392b00ec026a9 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 29 Mar 2013 09:14:45 -0700 Subject: commit_log: fix questionable code Perlcritc complains: scripts/vyatta-log-commit.pl: Variable declared in conditional statement at line 40, column 1. Declare variables outside of the condition. (Severity: 5) --- scripts/vyatta-log-commit.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/vyatta-log-commit.pl b/scripts/vyatta-log-commit.pl index bbf0852..7fa41a3 100644 --- a/scripts/vyatta-log-commit.pl +++ b/scripts/vyatta-log-commit.pl @@ -37,7 +37,8 @@ use POSIX qw(ttyname); # main # my $status = $ENV{'COMMIT_STATUS'}; -my $commit_status = 'Successful' if ($status eq 'SUCCESS'); +my $commit_status; +$commmit_status = 'Successful' if ($status eq 'SUCCESS'); #open log for logging commit details if (defined $commit_status) { my $cur_tty = ttyname(0); -- cgit v1.2.3