From fa38551031d0a0e37663fe465b3847f652b2c5a4 Mon Sep 17 00:00:00 2001 From: Stig Thormodsrud Date: Mon, 29 Nov 2010 15:57:22 -0800 Subject: Fix 5163: 'show firewall' displays misleading output when firewall groups are used Replace "show firewall" with "show firewall detail" output. --- templates/show/firewall/modify/detail/node.def | 2 -- templates/show/firewall/modify/node.def | 2 +- templates/show/firewall/modify/node.tag/detail/node.def | 3 --- templates/show/firewall/modify/node.tag/detail/rule/node.def | 1 - .../show/firewall/modify/node.tag/detail/rule/node.tag/node.def | 8 -------- templates/show/firewall/modify/node.tag/node.def | 2 +- templates/show/firewall/modify/node.tag/rule/node.tag/node.def | 2 +- 7 files changed, 3 insertions(+), 17 deletions(-) delete mode 100644 templates/show/firewall/modify/detail/node.def delete mode 100644 templates/show/firewall/modify/node.tag/detail/node.def delete mode 100644 templates/show/firewall/modify/node.tag/detail/rule/node.def delete mode 100644 templates/show/firewall/modify/node.tag/detail/rule/node.tag/node.def (limited to 'templates/show/firewall/modify') diff --git a/templates/show/firewall/modify/detail/node.def b/templates/show/firewall/modify/detail/node.def deleted file mode 100644 index 5fb43bc..0000000 --- a/templates/show/firewall/modify/detail/node.def +++ /dev/null @@ -1,2 +0,0 @@ -help: Show detailed firewall information -run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_all" /opt/vyatta/share/xsl/show_firewall_detail.xsl diff --git a/templates/show/firewall/modify/node.def b/templates/show/firewall/modify/node.def index cbd2fc6..8a16e04 100644 --- a/templates/show/firewall/modify/node.def +++ b/templates/show/firewall/modify/node.def @@ -1,2 +1,2 @@ help: Show IPv4 firewall modify chains -run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_all" /opt/vyatta/share/xsl/show_firewall.xsl +run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_all" /opt/vyatta/share/xsl/show_firewall_detail.xsl diff --git a/templates/show/firewall/modify/node.tag/detail/node.def b/templates/show/firewall/modify/node.tag/detail/node.def deleted file mode 100644 index 3e11efe..0000000 --- a/templates/show/firewall/modify/node.tag/detail/node.def +++ /dev/null @@ -1,3 +0,0 @@ -help: Show detailed IPv4 firewall modify rules information - -run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_$4" /opt/vyatta/share/xsl/show_firewall_detail.xsl diff --git a/templates/show/firewall/modify/node.tag/detail/rule/node.def b/templates/show/firewall/modify/node.tag/detail/rule/node.def deleted file mode 100644 index b67d3eb..0000000 --- a/templates/show/firewall/modify/node.tag/detail/rule/node.def +++ /dev/null @@ -1 +0,0 @@ -help: Show detailed IPv4 firewall modify rules information diff --git a/templates/show/firewall/modify/node.tag/detail/rule/node.tag/node.def b/templates/show/firewall/modify/node.tag/detail/rule/node.tag/node.def deleted file mode 100644 index c69f5ac..0000000 --- a/templates/show/firewall/modify/node.tag/detail/rule/node.tag/node.def +++ /dev/null @@ -1,8 +0,0 @@ -help: Show detailed information for specified IPv4 firewall modify rule - -allowed: local -a vals - eval "vals=($(cli-shell-api listActiveNodes \ - firewall modify ${COMP_WORDS[COMP_CWORD-3]} rule))" - echo -n ${vals[@]} - -run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_$4" /opt/vyatta/share/xsl/show_firewall_detail.xsl "$7" diff --git a/templates/show/firewall/modify/node.tag/node.def b/templates/show/firewall/modify/node.tag/node.def index bdae565..096bac0 100644 --- a/templates/show/firewall/modify/node.tag/node.def +++ b/templates/show/firewall/modify/node.tag/node.def @@ -4,4 +4,4 @@ allowed: local -a vals eval "vals=($(cli-shell-api listActiveNodes firewall modify))" echo -n ${vals[@]} -run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_$4" /opt/vyatta/share/xsl/show_firewall.xsl +run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_$4" /opt/vyatta/share/xsl/show_firewall_detail.xsl diff --git a/templates/show/firewall/modify/node.tag/rule/node.tag/node.def b/templates/show/firewall/modify/node.tag/rule/node.tag/node.def index d6cae43..e79461e 100644 --- a/templates/show/firewall/modify/node.tag/rule/node.tag/node.def +++ b/templates/show/firewall/modify/node.tag/rule/node.tag/node.def @@ -5,4 +5,4 @@ allowed: local -a vals firewall modify ${COMP_WORDS[COMP_CWORD-2]} rule))" echo -n ${vals[@]} -run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_$4" /opt/vyatta/share/xsl/show_firewall.xsl "$6" +run: ${vyatta_bindir}/vyatta-show-firewall.pl "$3_$4" /opt/vyatta/share/xsl/show_firewall_detail.xsl "$6" -- cgit v1.2.3