From d530a13a42bb1f0fb8facb1828813939d3c0fa1a Mon Sep 17 00:00:00 2001 From: John Estabrook Date: Mon, 10 Aug 2026 12:31:41 -0500 Subject: T9168: pin version 3.1.1 of ocaml-protoc / pbrt The automated review 0d61bd73fc was incorrect: the files were in fact generated by ocaml-protoc 3.1.1, and that is the stable and tested version for generation/build. Versions of ocaml-protoc / pbrt >= 4.x are not appropriate for regenerating *_pbrt files. However, versions < 3 are not appropriate for building the package. --- vyconf.opam | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/vyconf.opam b/vyconf.opam index 1b1958d..e7c089a 100644 --- a/vyconf.opam +++ b/vyconf.opam @@ -16,11 +16,7 @@ build: [ depends: [ "menhir" {build} "dune" {build & >= "1.4.0"} - # The committed src/*_pbt.ml were generated by ocaml-protoc 2.x. Version 3.0 - # emits private record types with presence tracking, which the hand-written - # call sites cannot construct. Pin to 2.x until the generated code + call - # sites are migrated to the 3.x API. - "ocaml-protoc" {build & < "3.0"} + "ocaml-protoc" {build & = "3.1.1"} "ounit2" {build} "vyos1x-config" {build} "lwt" {build & >= "4.1.0"} -- cgit v1.2.3