VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git) https://git.amelek.net/vyos/vyos-1x.git/atom?h=feature%2FT9082-codeql-cpp 2026-02-17T15:37:33+00:00 2026-02-17T15:37:33+00:00 Christian Breunig christian@breunig.cc 2026-02-17T15:35:23+00:00 urn:sha1:95bd2ebdcb30246d1f585ccb0336b3f3aa5519c7 Commit 395e3cb72 ("syslog: T6989: remove 'file' logging destination") removed CLI support for custom file based logging targets. The code about logrotate was not removed and just stayed "dead". Dead code is removed by this commit. 2026-02-10T03:59:37+00:00 Adam Schultz adam.schultz@live.com 2026-01-24T14:55:14+00:00 urn:sha1:696df602557dd7b70b353c3b9cfb110c0908a2fe 1.) Fix both syslog and logrotate writing /etc/logrotate.d/vyos-rsyslog - system_syslog.py generates /etc/logrotate.d/vyos-rsyslog-user for user file logrotate - system_logs.py generates /etc/logrotate.d/vyos-rsyslog using configured rotation parameters 2.) Fix /run/rsyslog/rsyslog.conf ignoring configured size for /var/log/messages - system_syslog.py retrieves "system logs" config to set rotation limits - default rotation size is now based on configuration defaults 3.) prifilt strings for rsyslog are modified to use override syntax (e.g. ";facility.none") when all is combined with other facilities to honor per facility user intent Smoke test changes: Commonize configuration of syslog facilities Check that prifilt is sane based on configured facilities (i.e. overides only present when required) Test wildcard (all) only, specific facility only, and wildcard + specific facility 2024-07-03T14:02:07+00:00 John Estabrook jestabro@vyos.io 2024-07-03T13:57:33+00:00 urn:sha1:977d2fbf7a62a97d98b38cf28e62f08fc9e8d3a2 2023-12-31T22:49:48+00:00 Christian Breunig christian@breunig.cc 2023-12-30T22:25:20+00:00 urn:sha1:4ef110fd2c501b718344c72d495ad7e16d2bd465 We will use _ as CLI level divider. The XML definition filename and also the Python helper should match the CLI node. Example: set interfaces ethernet -> interfaces_ethernet.xml.in set interfaces bond -> interfaces_bond.xml.in set service dhcp-server -> service_dhcp-server-xml.in 2023-07-16T20:03:48+00:00 Christian Breunig christian@breunig.cc 2023-07-16T20:03:06+00:00 urn:sha1:751d326c7769ac18db69de8f2be39587148be209 There was no /var/log/messages handler for logrotate making rsyslog crash after a few days. In addition we had some JIna2 templating errors for hosts, user and file CLI nodes jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'facility' Looks like therey are used rarely ;) - lucky me! 2023-05-08T20:45:53+00:00 Christian Breunig christian@breunig.cc 2023-05-08T19:27:14+00:00 urn:sha1:1dc79cebc6d27a8f9d2f9ca9c2e0f2fd0809d940