vyos-1x.git/interface-definitions/flow-accounting-conf.xml.in, branch feature/T9082-codeql-cpp

T5474: establish common file name pattern for XML conf mode commands

2023-12-31T22:49:48+00:00

We will use _ as CLI level divider. The XML definition filename and also the Python helper should match the CLI node. Example: set interfaces ethernet -> interfaces_ethernet.xml.in set interfaces bond -> interfaces_bond.xml.in set service dhcp-server -> service_dhcp-server-xml.in

T5226: Combine ipv4-address and ipv6-address validators

2023-05-17T04:10:36+00:00

Use a single ip-address validator to combine and replace ipv4-address and ipv6-address validators.

xml: flow-accounting: T4437: fix node help

2022-05-21T19:48:50+00:00

xml: T4047: use full string match in the regex validator

2022-04-29T17:51:50+00:00

flow-accounting: T4277: support sending flow-data via VRF interface

2022-03-01T18:10:15+00:00

It should be possible to send the gathered data via a VRF bound interface to the collector. This is somehow related to T3981 but it's the opposite side of the netflow process. set system flow-accounting vrf

scripts: T4269: node.def generator should automatically add default values

2022-02-24T21:47:12+00:00

Since introducing the XML node it was common, but redundant, practice to also add a help string indicating which value would be used as default if the node is unset. This makes no sense b/c it's duplicated code/value/characters and prone to error. The node.def scripts should be extended to automatically render the appropriate default value into the CLI help string. For e.g. SSH the current PoC renders: $ cat templates-cfg/service/ssh/port/node.def multi: type: txt help: Port for SSH service (default: 22) val_help: u32:1-65535; Numeric IP port ... Not all subsystems are already migrated to get_config_dict() and make use of the defaults() call - those subsystems need to be migrated, first before the new default is added to the CLI help.

flow-accounting: T4106: support specification of capture packet length

2021-12-25T22:27:15+00:00

flow-accounting: T4105: drop "sflow agent-address auto"

2021-12-25T22:27:15+00:00

The implementation of the "auto" option to specify the sflow/netflow agent-address is very error prone. The current implementation will determine the IP address used for the "auto" value as follow: Get BGP router-id 1) If not found use OSPF router-id 2) If not found use OSPFv3 router-id 3) If not found use "the first IP address found on the system Well, what is the "first IP address found"? Also this changes if DHCP is in use. Also another disadvantage is when the BGP/OSPF/OSPFv3 router-id is changed, the agent-address is not updated upon the next reboot of the system. This task is about removing the "auto" keyword from the CLI at all and make it either entirely configurable by the user and hardcode the value in CLI, or not use this at all. If "auto" is specified we will query the system in the above order and set the proper router-id in the CLI. If none can be found the CLI node is removed.

flow-accounting: T4099: rename "netflow source-ip" to source-address

2021-12-25T22:27:15+00:00

sFlow uses the source-address CLI node and netflow uses source-ip this is just confusing and should be synced to the common source-address CLI node.

flow-accounting: T4097: move to get_config_dict()

2021-12-25T22:27:15+00:00