vyos-1x.git/smoketest/scripts/cli/base_interfaces_test.py, branch rolling

smoketest: T9048: keep VRF and cmdline assertions on the same PID

2026-07-03T16:28:22+00:00

Adversarial review findings on the previous head: * get_process_cmdline() could re-resolve a NEW PID after the 'ip vrf pids' membership assertion had already run against the old one, so the two assertions could validate different processes. The helper now returns the (pid, cmdline) pair it actually validated and the VRF checks moved after it, targeting the returned PID. * The one-shot retry left a residual double-race window. The helper now polls PID discovery and the /proc read together under the same PROCESS_WAIT_TIMEOUT deadline. 🤖 Generated by [robots](https://vyos.io)

smoketest: T9048: guard the retry read in get_process_cmdline() too

2026-07-03T16:16:09+00:00

The re-resolve path read /proc//cmdline without defaultonfailure, so a repeated PID race raised an unhandled exception (test ERROR) instead of failing with a clear assertion message. 🤖 Generated by [robots](https://vyos.io)

smoketest: T9048: harden DHCP client process checks against CI timing races

2026-07-03T14:38:15+00:00

Interface smoketests fail intermittently in CI on DHCP-related assertions (test_interfaces_cli job pass rate 42-55% over the last 30 workflow runs). Three timing hazards in the interface test base class: * process_named_running() was polled with a 10 second window at all dhclient/dhcp6c call sites - too short on a loaded runner. Raise to a shared PROCESS_WAIT_TIMEOUT of 60 seconds; the poll returns as soon as the process appears, so this only delays the failure path. * /proc//cmdline was read unguarded after PID discovery. dhclient re-executes itself while daemonizing, so the discovered PID can be gone by the time /proc is read - read_file() then raises and the test errors out instead of failing cleanly. New get_process_cmdline() helper re-resolves the PID once when the read fails. * tearDown() asserted daemon absence immediately after the config was removed, reporting daemons still in their shutdown path as leaks. Use the existing wait_for_result() shim helper with the same 60s bound to grant a grace period before declaring a leak; the poll returns on first observation of a clean state, so passing runs pay no extra wall clock. 🤖 Generated by [robots](https://vyos.io)

T8923: normalize "can not" to "cannot"

2026-06-16T18:24:44+00:00

Replace two-word "can not" / "Can not" with "cannot" across comments, ConfigError messages, CLI help text, and op-mode output. Standard SNMP MIB files under mibs/ are left unchanged.

T8410: Fix typos and mistakes for comments and messages

2026-03-27T15:00:17+00:00

Fix typos and mistakes No functional changes

vyos.ifconfig: T8358: clear qdiscs when deleting mirror CLI node

2026-03-10T04:15:32+00:00

When removing the mirror CLI node to stop mirroring or redirecting traffic to another interface, the egress configuration was not cleared. This caused traffic to continue being sent out the SPAN port even after the node was removed. Fix by properly clearing all tc(8) qdiscs. Update smoketests to verify nothing remains after mirror deletion.

smoketest: T8023: adjust base interface test for Vlan MTUs

2025-11-21T19:39:06+00:00

Some drivers are limited to an MTU of 1500 byte - e.g. when VyOS runs on PROXMOX with default bridge settings. We use lower values for the testcase test_vif_8021q_mtu_limits which will fit for almost every NIC, but keep the testcase logic intact.

T7948: always call setUp() and tearDown() base class methods

2025-10-21T19:03:16+00:00

While working on task T7664 (FRR 10.4 upgrade), I identified the need for additional validation and safeguards around the FRR management daemon. The most appropriate place for this logic is in the setUp() and tearDown() methods of the smoketest base class, VyOSUnitTestSHIM. However, during implementation, it became apparent that test cases do not consistently invoke the base class's setup and teardown methods. This inconsistency complicates the process of capturing the FRR mgmtd PID at the start of a test and verifying that it remains unchanged by the end - a key step in detecting crashes or unexpected terminations (e.g., SIGSEGV) of the FRR management daemon during tests.

frr: T7664: remove CSTORE_GUARD_TIME from smoketests

2025-10-16T14:25:38+00:00

smoketest: T7858: use pylint for our testcases

2025-09-30T15:25:25+00:00