<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos-1x.git/smoketest/scripts/cli/base_vyostest_shim.py, branch rolling</title>
<subtitle>VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos-1x.git/atom?h=rolling</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos-1x.git/atom?h=rolling'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/'/>
<updated>2026-06-16T18:24:44+00:00</updated>
<entry>
<title>T8923: normalize "can not" to "cannot"</title>
<updated>2026-06-16T18:24:44+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2026-06-16T18:24:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=fa853ed8f25b5b9bf396d6e819b2c6259e7f5f42'/>
<id>urn:sha1:fa853ed8f25b5b9bf396d6e819b2c6259e7f5f42</id>
<content type='text'>
Replace two-word "can not" / "Can not" with "cannot" across comments,
ConfigError messages, CLI help text, and op-mode output.

Standard SNMP MIB files under mibs/ are left unchanged.
</content>
</entry>
<entry>
<title>smoketests: T8845: missing base-class call to commit() in tearDownClass()</title>
<updated>2026-05-11T18:14:58+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2026-05-11T15:58:16+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=ba7da49727661a1b502844eca1445016353ffb92'/>
<id>urn:sha1:ba7da49727661a1b502844eca1445016353ffb92</id>
<content type='text'>
The smoketest framework heavily relies on deriving common code paths. The
tearDownClass() is called when a testcase finishes and testcases like protocols
BGP delete CLI nodes before calling the base class.

The base-class never calls commit() thus the deletions are discarded instead
of committed.

test_protocols_bgp.py
  @classmethod
  def tearDownClass(cls):
      cls.cli_delete(cls, ['policy', 'route-map'])
      cls.cli_delete(cls, ['policy', 'prefix-list'])
      cls.cli_delete(cls, ['policy', 'prefix-list6'])

      super(TestProtocolsBGP, cls).tearDownClass()

base class base_vyostest_shim.py

  @classmethod
  def tearDownClass(cls):
      # discard any pending changes which might caused a messed up config
      cls._session.discard()
</content>
</entry>
<entry>
<title>T8465: Fix test_06_dhcp_default_route_for_vrf</title>
<updated>2026-04-09T06:22:42+00:00</updated>
<author>
<name>Kyrylo Yatsenko</name>
<email>hedrok@gmail.com</email>
</author>
<published>2026-04-08T18:27:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=3a21052c3167777354a6e4f4bb4a225b1294b3e7'/>
<id>urn:sha1:3a21052c3167777354a6e4f4bb4a225b1294b3e7</id>
<content type='text'>
* Add wait_for_result function to VyOSUnitTestSHIM.
* Use it for periodic polling in test_06_dhcp_default_route_for_vrf
* Move interface removal from VRF before assert.
</content>
</entry>
<entry>
<title>T8410: Fix typos and mistakes for comments and messages</title>
<updated>2026-03-27T15:00:17+00:00</updated>
<author>
<name>Viacheslav Hletenko</name>
<email>v.gletenko@vyos.io</email>
</author>
<published>2026-03-27T14:43:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=139b0841f8242a5c6ebdafb37380c1fb78342aae'/>
<id>urn:sha1:139b0841f8242a5c6ebdafb37380c1fb78342aae</id>
<content type='text'>
Fix typos and mistakes
No functional changes
</content>
</entry>
<entry>
<title>smoketest: T7996: drop frr-reload.py implementation when reading running config</title>
<updated>2025-11-07T15:45:58+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2025-11-07T15:45:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=b50808ac8245aa75bdca5b1996847125d1969dc3'/>
<id>urn:sha1:b50808ac8245aa75bdca5b1996847125d1969dc3</id>
<content type='text'>
Commit 9775bb49e ("frr: T7664: drop BASH/SED implementation in smoketest
getFRRconfig()") dropped a custom BASH/SED based implementation of how we
interacted with FRR to make use of the utility helpers from FRR team.

This changed added some arbitray warnings when executing about unclosed
files handles. ResourceWarning: unclosed file &lt;_io.BufferedReader name=5&gt;

Instead of importing the frr-reload Python module, we simply call popen() by
ourself.
</content>
</entry>
<entry>
<title>smoketest: T7966: perform full regex match with ^ and $</title>
<updated>2025-11-07T15:41:14+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2025-11-07T15:41:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=316b31e304db92d87e63321628be21f9f4cd1387'/>
<id>urn:sha1:316b31e304db92d87e63321628be21f9f4cd1387</id>
<content type='text'>
Commit 9775bb49e ("frr: T7664: drop BASH/SED implementation in smoketest
getFRRconfig()") changed how we searched strings using a regex. In the
past we searched at the beginning of a line ^ till the end $. THis logic
was dropped in commit 9775bb49e marking some tests failing as they matched,
when they should not match.

Example: getFRRconfig('vrf red') showed output for both VRF red and red15 as
both started with "red". This has been fixed.
</content>
</entry>
<entry>
<title>smoketests: T7971: Add docstrings to nftables verification helpers</title>
<updated>2025-10-29T23:43:51+00:00</updated>
<author>
<name>l0crian1</name>
<email>ryan.claridge13@gmail.com</email>
</author>
<published>2025-10-29T23:43:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=27645da088567aa6e2c0d15dd49e92ba2fd721ec'/>
<id>urn:sha1:27645da088567aa6e2c0d15dd49e92ba2fd721ec</id>
<content type='text'>
</content>
</entry>
<entry>
<title>smoketest: T7948: always verify FRRs mgmtd PID is unchanged</title>
<updated>2025-10-21T19:03:16+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2025-10-20T16:56:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=b1d8f616ffd6a3eb27e28b2a1d2be30496604af6'/>
<id>urn:sha1:b1d8f616ffd6a3eb27e28b2a1d2be30496604af6</id>
<content type='text'>
Upgrades to FRR 10.4 have shown that there are cases where FRRs mgmtd will
SIGSEGV - to cover for this case and fail the smoketests we will monitor the
PID of the mgmtd process.
</content>
</entry>
<entry>
<title>T7948: always call setUp() and tearDown() base class methods</title>
<updated>2025-10-21T19:03:16+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2025-10-20T16:52:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=4995a58f998d3bdd055e49e919945bc0aa939be4'/>
<id>urn:sha1:4995a58f998d3bdd055e49e919945bc0aa939be4</id>
<content type='text'>
While working on task T7664 (FRR 10.4 upgrade), I identified the need for
additional validation and safeguards around the FRR management daemon. The
most appropriate place for this logic is in the setUp() and tearDown() methods
of the smoketest base class, VyOSUnitTestSHIM.

However, during implementation, it became apparent that test cases do not
consistently invoke the base class's setup and teardown methods. This
inconsistency complicates the process of capturing the FRR mgmtd PID at the
start of a test and verifying that it remains unchanged by the end - a key step
in detecting crashes or unexpected terminations (e.g., SIGSEGV) of the FRR
management daemon during tests.
</content>
</entry>
<entry>
<title>frr: T7664: drop BASH/SED implementation in smoketest getFRRconfig()</title>
<updated>2025-10-16T14:33:44+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2025-10-14T15:37:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=9775bb49e4d42c7bf09f4d78b404b5b39b47b11f'/>
<id>urn:sha1:9775bb49e4d42c7bf09f4d78b404b5b39b47b11f</id>
<content type='text'>
Rathern then re-inventing the wheel by outself we import the frr-reload.py
script and their read-in function of the current vtysh configuration.
</content>
</entry>
</feed>
