<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos-1x.git/src/conf_mode/firewall_options.py, branch feature/T9082-codeql-cpp</title>
<subtitle>VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos-1x.git/atom?h=feature%2FT9082-codeql-cpp</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos-1x.git/atom?h=feature%2FT9082-codeql-cpp'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/'/>
<updated>2021-08-21T13:26:35+00:00</updated>
<entry>
<title>interfaces: T3090: migrate adjust-mss from "firewall options" to "interface" level</title>
<updated>2021-08-21T13:26:35+00:00</updated>
<author>
<name>Christian Poessinger</name>
<email>christian@poessinger.com</email>
</author>
<published>2021-08-19T16:14:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=b7bfcb6ef0e712bb8c39241051e716a833b2ffe8'/>
<id>urn:sha1:b7bfcb6ef0e712bb8c39241051e716a833b2ffe8</id>
<content type='text'>
Getting rid of "set firewall options" and move it from:

set firewall options interface ethX adjust-mss 1400
set firewall options interface ethX adjust-mss6 1400

to:

set interfaces ethernet ethX ip adjust-mss 1400
set interfaces ethernet ethX ipv6 adjust-mss 1400

In addition add an extra option called clamp-mss-to-pmtu instead of a value.
</content>
</entry>
<entry>
<title>configd: T2582: add scripts to include list for daemon</title>
<updated>2020-08-31T14:57:00+00:00</updated>
<author>
<name>John Estabrook</name>
<email>jestabro@vyos.io</email>
</author>
<published>2020-08-28T20:50:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=ad69fb36201ee0930b76d80f0869284e26846991'/>
<id>urn:sha1:ad69fb36201ee0930b76d80f0869284e26846991</id>
<content type='text'>
</content>
</entry>
<entry>
<title>airbag: T2088: explicit enabling of the feature</title>
<updated>2020-05-29T05:37:00+00:00</updated>
<author>
<name>Thomas Mangin</name>
<email>thomas.mangin@exa.net.uk</email>
</author>
<published>2020-05-29T05:37:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=5f4335042cf40bf4bf18294706cce0b3a2fd5907'/>
<id>urn:sha1:5f4335042cf40bf4bf18294706cce0b3a2fd5907</id>
<content type='text'>
airbag must now be explicitly installed.

the patch also allow to fully disables the installation of the logging
code at setup (and not just installing and doing nothing)
</content>
</entry>
<entry>
<title>util: T2226: os.system was wrongly converted to run</title>
<updated>2020-04-09T18:08:24+00:00</updated>
<author>
<name>Thomas Mangin</name>
<email>thomas.mangin@exa.net.uk</email>
</author>
<published>2020-04-09T18:08:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=9875a21bdb26df19f2faf3e81153dea15e4f9e3c'/>
<id>urn:sha1:9875a21bdb26df19f2faf3e81153dea15e4f9e3c</id>
<content type='text'>
os.system does print the ouput of the command, run() does not.
A new function called call() does the printing and return the error code.</content>
</entry>
<entry>
<title>util: T2226: covert most calls from os.system to util</title>
<updated>2020-04-06T19:22:35+00:00</updated>
<author>
<name>Thomas Mangin</name>
<email>thomas.mangin@exa.net.uk</email>
</author>
<published>2020-04-05T13:36:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=aceb0817a65bf01669cada3ceb60d65b81607bc3'/>
<id>urn:sha1:aceb0817a65bf01669cada3ceb60d65b81607bc3</id>
<content type='text'>
As little change a possible but the function call
The behaviour should be totally unchanged.
</content>
</entry>
<entry>
<title>firewall: T1461: deleting 'firewall options' causes Python TypeError</title>
<updated>2019-06-20T20:14:36+00:00</updated>
<author>
<name>Christian Poessinger</name>
<email>christian@poessinger.com</email>
</author>
<published>2019-06-20T20:14:36+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=efb1a1c88f436a3704c4ca6e15b65aeded4b9654'/>
<id>urn:sha1:efb1a1c88f436a3704c4ca6e15b65aeded4b9654</id>
<content type='text'>
[ firewall options interface wg01 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/firewall_options.py", line 139, in &lt;module&gt;
    apply(c)
  File "/usr/libexec/vyos/conf_mode/firewall_options.py", line 97, in apply
    if tcp['new_chain4']:
TypeError: 'NoneType' object is not subscriptable

delete [ firewall options ] failed
delete [ firewall ] failed
Commit failed
</content>
</entry>
<entry>
<title>[firewall] T314: add firewall options for MSS clamping</title>
<updated>2019-04-21T11:21:12+00:00</updated>
<author>
<name>Christian Poessinger</name>
<email>christian@poessinger.com</email>
</author>
<published>2019-04-21T11:19:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=7d024a324412f4902b9ba212277901bbbe2f949c'/>
<id>urn:sha1:7d024a324412f4902b9ba212277901bbbe2f949c</id>
<content type='text'>
* clamp MSS IPv4
  set firewall options interface pppoe0 adjust-mss '1452'

* clamp MSS IPv6
  set firewall options interface pppoe0 adjust-mss6 '1452'

* disable entire rule
  set firewall options interface pppoe0 disable

Output
------

  $ sudo iptables-save -t mangle
  # Generated by iptables-save v1.4.21 on Sun Apr 21 12:56:25 2019
  *mangle
  :PREROUTING ACCEPT [1217:439885]
  :INPUT ACCEPT [290:52459]
  :FORWARD ACCEPT [920:375774]
  :OUTPUT ACCEPT [301:100053]
  :POSTROUTING ACCEPT [1221:475827]
  :VYOS_FW_OPTIONS - [0:0]
  -A FORWARD -j VYOS_FW_OPTIONS
  -A VYOS_FW_OPTIONS -o pppoe0 -p tcp -m tcp --tcp-flags SYN,RST SYN -j TCPMSS --set-mss 1452
  COMMIT
  Completed on Sun Apr 21 12:56:25 2019

(cherry picked from commit 476aa4c3a561ea0ef0bf9b4c26ec8b78d18a5d02)
</content>
</entry>
</feed>
