VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git) https://git.amelek.net/vyos/vyos-1x.git/atom?h=feature%2FT9082-codeql-cpp 2023-12-31T22:49:48+00:00 2023-12-31T22:49:48+00:00 Christian Breunig christian@breunig.cc 2023-12-30T22:25:20+00:00 urn:sha1:4ef110fd2c501b718344c72d495ad7e16d2bd465 We will use _ as CLI level divider. The XML definition filename and also the Python helper should match the CLI node. Example: set interfaces ethernet -> interfaces_ethernet.xml.in set interfaces bond -> interfaces_bond.xml.in set service dhcp-server -> service_dhcp-server-xml.in 2023-08-07T19:46:42+00:00 John Estabrook jestabro@vyos.io 2023-08-07T01:54:05+00:00 urn:sha1:e4f6495598d60a41963cf2e6f29fa4743af4a036 2023-07-18T18:52:49+00:00 John Estabrook jestabro@vyos.io 2023-07-18T18:52:49+00:00 urn:sha1:f14a98b613b01aa12a5ab39682054494850d1043 2023-07-17T14:57:54+00:00 John Estabrook jestabro@vyos.io 2023-07-17T14:57:54+00:00 urn:sha1:b2ffdb756f797787a639343bebb02e327e54483c 2023-07-16T20:03:48+00:00 Christian Breunig christian@breunig.cc 2023-07-16T20:03:06+00:00 urn:sha1:751d326c7769ac18db69de8f2be39587148be209 There was no /var/log/messages handler for logrotate making rsyslog crash after a few days. In addition we had some JIna2 templating errors for hosts, user and file CLI nodes jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'facility' Looks like therey are used rarely ;) - lucky me! 2023-07-14T20:18:36+00:00 Christian Breunig christian@breunig.cc 2023-07-14T20:18:36+00:00 urn:sha1:d1ca536da448749dff557f13ecae97b124026e96 * T5195: move run, cmd, call, rc_cmd helper to vyos.utils.process * T5195: use read_file and write_file implementation from vyos.utils.file Changed code automatically using: find . -type f -not -path '*/\.*' -exec sed -i 's/^from vyos.util import read_file$/from vyos.utils.file import read_file/g' {} + find . -type f -not -path '*/\.*' -exec sed -i 's/^from vyos.util import write_file$/from vyos.utils.file import write_file/g' {} + * T5195: move chmod* helpers to vyos.utils.permission * T5195: use colon_separated_to_dict from vyos.utils.dict * T5195: move is_systemd_service_* to vyos.utils.process * T5195: fix boot issues with missing imports * T5195: move dict_search_* helpers to vyos.utils.dict * T5195: move network helpers to vyos.utils.network * T5195: move commit_* helpers to vyos.utils.commit * T5195: move user I/O helpers to vyos.utils.io 2023-05-14T11:50:33+00:00 Joe Groocock me@frebib.net 2023-05-14T11:50:33+00:00 urn:sha1:85b7b4fea9a5e9fdcfe138ec1f1816594fee70ea Avoids the following warning, and any external service from re-activating syslog via systemd socket activation: frebib@vyos# commit [ system syslog ] DEBUG/COMMAND returned (err): Warning: Stopping syslog.service, but it can still be activated by: syslog.socket DEBUG/COMMAND cmd 'systemctl stop syslog.service' Signed-off-by: Joe Groocock <me@frebib.net> 2023-05-14T11:43:52+00:00 Joe Groocock me@frebib.net 2023-05-14T11:42:21+00:00 urn:sha1:151f851502c8f7ec09d411a8a81452f7a7d64042 os.unlink() is the correct function: Traceback (most recent call last): File "/usr/libexec/vyos/conf_mode/system-syslog.py", line 146, in <module> generate(c) File "/usr/libexec/vyos/conf_mode/system-syslog.py", line 114, in generate os.path.unlink(rsyslog_conf) ^^^^^^^^^^^^^^ AttributeError: module 'posixpath' has no attribute 'unlink' Signed-off-by: Joe Groocock <me@frebib.net> 2023-05-08T20:45:53+00:00 Christian Breunig christian@breunig.cc 2023-05-08T20:34:22+00:00 urn:sha1:46d2bcdb0b500b4d1b9d973ab5b9ca3c6cf44e51 Allow syslog messages to be sent through a VRF (e.g. management). 2023-05-08T20:45:53+00:00 Christian Breunig christian@breunig.cc 2023-05-08T19:27:14+00:00 urn:sha1:1dc79cebc6d27a8f9d2f9ca9c2e0f2fd0809d940