VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git) https://git.amelek.net/vyos/vyos-1x.git/atom?h=equuleus 2024-01-12T20:53:17+00:00 2024-01-12T20:53:17+00:00 Christian Breunig christian@breunig.cc 2024-01-12T20:53:17+00:00 urn:sha1:516c2c43392907493f4157ea7d6d2149b725688b The original commit 2c1c36135 ("wireguard: T5413: Blocked adding the peer with the router's public key") did not honor the fact that there might be no private-key CLI node defined for a WireGuard interface. If this is the case, private-key defaults to "default". This fact needs to be handled in the migration script. 2023-11-24T14:57:10+00:00 aapostoliuk a.apostoliuk@vyos.io 2023-11-24T14:21:37+00:00 urn:sha1:2c1c3613567e23e14ce89bbf872e6e9dee16badb Disabled adding the peer with the same public key as the router has. Backport from current https://github.com/vyos/vyos-1x/pull/2122 2023-02-12T20:00:53+00:00 Christian Breunig christian@breunig.cc 2023-02-12T20:00:53+00:00 urn:sha1:b6290329f2d6f5d05a8ff577f0be8a7e0f0ebdee Replace links to the phabricator site from https://phabricator.vyos.net to https://vyos.dev (cherry-picked form commit bd9416a6aa9d5d0a746dc2cebc8d0330fd27d1a2) 2021-10-21T17:38:38+00:00 Christian Poessinger christian@poessinger.com 2021-10-21T17:38:38+00:00 urn:sha1:c1015d8ce0013719eb898b60b14ffec192b8141c 2021-08-31T21:36:14+00:00 Christian Poessinger christian@poessinger.com 2021-08-31T21:03:01+00:00 urn:sha1:b0d4112bd6073e4a947869c3bd80f8e87783fbfa It makes no sense to have a parser for the ethtool values in ethtool.py and ethernet.py - one instance ios more then enough! (cherry picked from commit 0229645c8248decb5664056df8aa5cd5dff41802) 2021-08-31T17:04:15+00:00 Christian Poessinger christian@poessinger.com 2021-08-31T16:15:47+00:00 urn:sha1:2bfd809e9ae198d95b9fcb556440637fdcc4005c Not all interface drivers have the ability to change the speed and duplex settings. Known drivers with this limitation are vmxnet3, virtio_net and xen_netfront. If this driver is detected, an error will be presented to the user. (cherry picked from commit cc742d48579e4f76e5d3230d87e22f71f76f9301) 2021-08-30T19:38:44+00:00 Christian Poessinger christian@poessinger.com 2021-08-30T19:36:52+00:00 urn:sha1:f5e46ee6cc2b6c1c1869e26beca4ccd5bf52b62f Deprecated in the Linux Kernel by commit 08a00fea6de277df12ccfadc21 ("net: Remove references to NETIF_F_UFO from ethtool."). 2021-08-30T19:38:44+00:00 Christian Poessinger christian@poessinger.com 2021-08-30T19:29:22+00:00 urn:sha1:a515212f4efb08846df04405f31a828edcd63552 An analysis of the code base from VyOS 1.2 -> 1.3 -> 1.4 revealed the following "root-cause" VyOS 1.2 uses the "old" node.def file format for: * Generic Segmentation Offloading * Generic Receive Offloading So if any of the above settings is available on the configuration CLI, the node.def file will be executed - this is how it works. By default, this CLI option is not enabled in VyOS 1.2 - but the Linux Kernel enables offloading "under the hood" by default for GRO, GSO... which will boost the performance for users magically. With the rewrite in VyOS 1.3 of all the interface related code T1579, and especially T1637 this was moved to a new approach. There is now only one handler script which is called whenever a user changes something under the interfaces ethernet tree. The Full CLI configuration is assembled by get_interface_dict() - a wrapper for get_config_dict() which abstracts and works for all of our interface types - single source design. The problem now comes into play when the gathered configuration is actually written to the hardware, as there is no GSO, GRO or foo-offloading setting defined - we behave as instructed and disable the offloading. So the real bug originates from VyOS 1.2 and the old Vyatta codebase, but the recent XML Python rewrites brought that one up to light. Solution: A configuration migration script will be provided starting with VyOS 1.3 which will read in the CLI configuration of the ethernet interfaces and if not enabled, will query the adapter if offloading is supported at all, and if so, will enable the CLI nodes. One might say that this will "blow" the CLI configuration but it only represents the truth - which was masked in VyOS 1.2. 2021-07-25T19:10:25+00:00 Christian Poessinger christian@poessinger.com 2021-07-25T09:49:05+00:00 urn:sha1:7a85dbfb8b97dade658e8213099fc4995ae62ea1 It is easier to backport the entire vyos.ifconfig library from 1.4 instead of backporting single pieces which are required to add new feature to the tunnel interface section. In addition that both libraries are now back in sync it will become much easier to backport any other new feature introduced in VyOS 1.4! 2021-06-13T09:20:08+00:00 Christian Poessinger christian@poessinger.com 2021-06-13T09:06:11+00:00 urn:sha1:0352aa560122146d761c7bbc00b008cd59a3fc97 (cherry picked from commit e24e35e1ac11a0771b15417af191694fd0b88022)