<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos-1x.git/src, branch mergify/bp/circinus/pr-3763</title>
<subtitle>VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos-1x.git/atom?h=mergify%2Fbp%2Fcircinus%2Fpr-3763</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos-1x.git/atom?h=mergify%2Fbp%2Fcircinus%2Fpr-3763'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/'/>
<updated>2024-07-30T12:21:51+00:00</updated>
<entry>
<title>ipsec: T6148: Fixed reset command by adding init after terminating (#3763)</title>
<updated>2024-07-30T12:21:51+00:00</updated>
<author>
<name>aapostoliuk</name>
<email>108394744+aapostoliuk@users.noreply.github.com</email>
</author>
<published>2024-07-28T12:54:08+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=9be079ac855b20622240c0e577c7f5db9d075798'/>
<id>urn:sha1:9be079ac855b20622240c0e577c7f5db9d075798</id>
<content type='text'>
Strongswan does not initiate session after termination via vici.
Added an CHILD SAs initialization on the initiator side
of the tunnel.

(cherry picked from commit 8838b29180ccc26d2aca0c22c9c8ca5e274825b2)
</content>
</entry>
<entry>
<title>vrf: T6603: improve code runtime when retrieving info from nftables vrf zone</title>
<updated>2024-07-30T07:47:39+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-26T11:43:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=ebac16ea3f242c0a5a35d38b65e549130db7b763'/>
<id>urn:sha1:ebac16ea3f242c0a5a35d38b65e549130db7b763</id>
<content type='text'>
(cherry picked from commit 31acb42ecdf4ecf0f636f831f42a845b8a00d367)
</content>
</entry>
<entry>
<title>vrf: T6603: conntrack ct_iface_map must only contain one entry for iifname/oifname</title>
<updated>2024-07-30T07:47:39+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-26T11:25:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=a05251f766c68fbff506bc01f6c095350f904bb7'/>
<id>urn:sha1:a05251f766c68fbff506bc01f6c095350f904bb7</id>
<content type='text'>
When any of the following features NAT, NAT66 or Firewall is enabled, for every
VRF on the CLI we install one rule into nftables for conntrack:

    chain vrf_zones_ct_in {
            type filter hook prerouting priority raw; policy accept;
            counter packets 3113 bytes 32227 ct original zone set iifname map @ct_iface_map
            counter packets 8550 bytes 80739 ct original zone set iifname map @ct_iface_map
            counter packets 5644 bytes 67697 ct original zone set iifname map @ct_iface_map
    }

This is superfluous.

(cherry picked from commit d6e9824f1612bd8c876437c071f31a1a0f44af5d)
</content>
</entry>
<entry>
<title>Merge pull request #3877 from vyos/mergify/bp/circinus/pr-3868</title>
<updated>2024-07-26T10:52:29+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-26T10:52:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=aaaabd60e2fedd9416d9de2932af2f122b33b67f'/>
<id>urn:sha1:aaaabd60e2fedd9416d9de2932af2f122b33b67f</id>
<content type='text'>
T6605: restore configd error formatting to be consistent with CLI (backport #3868)</content>
</entry>
<entry>
<title>vxlan: T6505: Support VXLAN VLAN-VNI range mapping in CLI (#3756)</title>
<updated>2024-07-26T09:36:35+00:00</updated>
<author>
<name>Nataliia S</name>
<email>81954790+natali-rs1985@users.noreply.github.com</email>
</author>
<published>2024-07-08T15:51:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=ce5460f0380a60eb07f70dfed29d1b011636448a'/>
<id>urn:sha1:ce5460f0380a60eb07f70dfed29d1b011636448a</id>
<content type='text'>
(cherry picked from commit 115e99630a317cab62c6f99e0461f6ce2c1edaf3)
</content>
</entry>
<entry>
<title>system_option: T5552: Apply IPv4 and IPv6 options after reapplying sysctls by TuneD (#3863)</title>
<updated>2024-07-25T16:07:28+00:00</updated>
<author>
<name>mergify[bot]</name>
<email>37929162+mergify[bot]@users.noreply.github.com</email>
</author>
<published>2024-07-25T16:07:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=609f4b9c1bb7f3144a997f76e74e86bef0559b23'/>
<id>urn:sha1:609f4b9c1bb7f3144a997f76e74e86bef0559b23</id>
<content type='text'>
(cherry picked from commit 7b82e4005724683c6311fab22358746f2cca4c1b)

Co-authored-by: Nataliia Solomko &lt;natalirs1985@gmail.com&gt;</content>
</entry>
<entry>
<title>T6605: restore configd error formatting to be consistent with CLI (#3868)</title>
<updated>2024-07-25T13:40:57+00:00</updated>
<author>
<name>John Estabrook</name>
<email>jestabro@vyos.io</email>
</author>
<published>2024-07-25T07:15:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=368cb359bfb38b7cde1c84147fd109a533c73c69'/>
<id>urn:sha1:368cb359bfb38b7cde1c84147fd109a533c73c69</id>
<content type='text'>
(cherry picked from commit 645f24908c9b338adc56ecc83f8c44d0b0206550)
</content>
</entry>
<entry>
<title>vrf: T6602: verify supplied VRF name on all interface types (#3870)</title>
<updated>2024-07-25T02:48:39+00:00</updated>
<author>
<name>mergify[bot]</name>
<email>37929162+mergify[bot]@users.noreply.github.com</email>
</author>
<published>2024-07-25T02:48:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=67695c3e7a0d9fdc10ad3e381ad67cb30688e217'/>
<id>urn:sha1:67695c3e7a0d9fdc10ad3e381ad67cb30688e217</id>
<content type='text'>
Only some (e.g. ethernet or wireguard) interfaces validate if the supplied VRF
actually exists. If this is not validated, one can pass an invalid VRF to the
system which generates an OSError exception.

To reproduce

set interfaces vxlan vxlan1 vni 1000
set interfaces vxlan vxlan1 remote 1.2.3.4
set interfaces vxlan vxlan1 vrf smoketest

results in

OSError: [Errno 255] failed to run command: ip link set dev vxlan1 master smoketest_mgmt

This commit adds the missing verify_vrf() call to the missing interface types
and an appropriate smoketest for all interfaces supporting VRF assignment.

(cherry picked from commit dd0ebffa33728e452ac6e11737c2283f0e390359)

Co-authored-by: Christian Breunig &lt;christian@breunig.cc&gt;</content>
</entry>
<entry>
<title>op_mode: T6596: pppoe operation command failed</title>
<updated>2024-07-24T08:51:50+00:00</updated>
<author>
<name>Nataliia Solomko</name>
<email>natalirs1985@gmail.com</email>
</author>
<published>2024-07-24T07:33:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=74e168aff5f6861820d7e0038bfd01e64b532642'/>
<id>urn:sha1:74e168aff5f6861820d7e0038bfd01e64b532642</id>
<content type='text'>
(cherry picked from commit 79407cd5bbec3194a9b6542418229b33eab05121)
</content>
</entry>
<entry>
<title>wireless: T6597: improve hostapd startup and corresponding smoketests</title>
<updated>2024-07-22T19:57:10+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-19T11:54:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=9516ae6ffafa5107ff7e6639c2a2303dc6bc9ae4'/>
<id>urn:sha1:9516ae6ffafa5107ff7e6639c2a2303dc6bc9ae4</id>
<content type='text'>
This was found during smoketesting as thoase started to repeadingly fail in the last weeks

  File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address
      self.assertTrue(process_named_running('hostapd'))
  AssertionError: None is not true

Digging into this revealed that this is NOT related to the smoketest coding but
to hostapd/systemd instead. With a configured WIFI interface and calling:
"sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short
period caused systemd to report:
"Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully."

According to the internal systemd logic used in our version this is explained by:

  /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not
   * undo what has already been enqueued. */
  if (unit_stop_pending(UNIT(s)))
          allow_restart = false;

  if (s-&gt;result == SERVICE_SUCCESS)
          s-&gt;result = f;

  if (s-&gt;result == SERVICE_SUCCESS) {
          unit_log_success(UNIT(s));
          end_state = SERVICE_DEAD;`

Where unit_log_success() generates the log message in question.

Improve the restart login in the wireless interface script and an upgrade to
hostapd solved the issue.

(cherry picked from commit a67f49d99eda00998c425f9a663e138dbd0f7755)
</content>
</entry>
</feed>
