vyos-1x.git/src, branch mergify/bp/circinus/pr-3833

wireless: T6597: improve hostapd startup and corresponding smoketests

2024-07-22T19:57:10+00:00

This was found during smoketesting as thoase started to repeadingly fail in the last weeks File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address self.assertTrue(process_named_running('hostapd')) AssertionError: None is not true Digging into this revealed that this is NOT related to the smoketest coding but to hostapd/systemd instead. With a configured WIFI interface and calling: "sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short period caused systemd to report: "Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully." According to the internal systemd logic used in our version this is explained by: /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not * undo what has already been enqueued. */ if (unit_stop_pending(UNIT(s))) allow_restart = false; if (s->result == SERVICE_SUCCESS) s->result = f; if (s->result == SERVICE_SUCCESS) { unit_log_success(UNIT(s)); end_state = SERVICE_DEAD;` Where unit_log_success() generates the log message in question. Improve the restart login in the wireless interface script and an upgrade to hostapd solved the issue. (cherry picked from commit a67f49d99eda00998c425f9a663e138dbd0f7755)

wireless: T6320: add 802.11ax at 6GHz

2024-07-22T19:54:55+00:00

Authored-By: Alain Lamar (cherry picked from commit d5e988ba2d0fa0189feff22374c9b46eb49e2e79)

openvpn: T3834: verify() is not allowed to change anything on the system

2024-07-22T17:20:11+00:00

Commit e3c71af1466 ("remove secrets file if the tunnel is deleted and fix opmode commands") added a code path into verify() which removed files on the system if TOTP was not defined. This commit moves the code path to the appropriate generate() function. (cherry picked from commit 40c835992db9217f48e54dbbf15a7fbf1dcba482)

T6599: ipsec: fix incorect default behavior for dead-peer-detection

2024-07-22T10:28:04+00:00

(cherry picked from commit 23a3419d512139650cfe3dc76759b370b0c0c3d6)

vrf: T6592: remove unused import get_interface_config

2024-07-21T07:35:21+00:00

Remove unused import (left over) from commit 36f3791e0 ("utils: migrate to new get_vrf_tableid() helper") (cherry picked from commit b551f542c5c906c901e3be37ad3fd68c8248473d)

utils: migrate to new get_vrf_tableid() helper

2024-07-20T14:21:20+00:00

Commit 452068ce7 ("interfaces: T6592: moving an interface between VRF instances failed") introduced a new helper to retrieve the VRF table ID from the Kernel. This commit migrates the old code path where the individual fields got queried to the new helper vyos.utils.network.get_vrf_tableid(). (cherry picked from commit 36f3791e0c15267483d59a3bb74465811d08df88)

T6578: Fix unhandled exception in "show openconnect-server sessions" (#3830)

2024-07-19T10:45:45+00:00

(cherry picked from commit e858d96a3fbc1ae4719a50ee67df02b2f256b40f) Co-authored-by: khramshinr

openvpn: T6591: deprecate OpenVPN server net30 topology (#3825)

2024-07-18T18:58:05+00:00

(cherry picked from commit e2b05343b30d2f989968532106e792cbaf75ecf6)

Merge pull request #3822 from vyos/mergify/bp/circinus/pr-3813

2024-07-18T12:15:27+00:00

configdep: T6559: fix regression in dependent script error under configd (backport #3813)

op-mode: T6577: create generic service restart helper to work with the API

2024-07-17T17:06:53+00:00

Right now we have multiple restart helpers (e.g. dhcp server, ssh, ntp) that all do the same (more or less): * Check if service is configured on CLI * Restart if configured * Error out if unconfigured This is not available via the op-mode API. Create a new restart.py op-mode helper that takes the service name and possible VRF as argument so it's also exposed via API. (cherry picked from commit c74ae852152b0c3c3f00a1847d081d28f500e178)