<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos-1x.git/src, branch mergify/bp/circinus/pr-3889</title>
<subtitle>VyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos/vyos-1x.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos-1x.git/atom?h=mergify%2Fbp%2Fcircinus%2Fpr-3889</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos-1x.git/atom?h=mergify%2Fbp%2Fcircinus%2Fpr-3889'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/'/>
<updated>2024-07-26T10:52:29+00:00</updated>
<entry>
<title>Merge pull request #3877 from vyos/mergify/bp/circinus/pr-3868</title>
<updated>2024-07-26T10:52:29+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-26T10:52:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=aaaabd60e2fedd9416d9de2932af2f122b33b67f'/>
<id>urn:sha1:aaaabd60e2fedd9416d9de2932af2f122b33b67f</id>
<content type='text'>
T6605: restore configd error formatting to be consistent with CLI (backport #3868)</content>
</entry>
<entry>
<title>vxlan: T6505: Support VXLAN VLAN-VNI range mapping in CLI (#3756)</title>
<updated>2024-07-26T09:36:35+00:00</updated>
<author>
<name>Nataliia S</name>
<email>81954790+natali-rs1985@users.noreply.github.com</email>
</author>
<published>2024-07-08T15:51:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=ce5460f0380a60eb07f70dfed29d1b011636448a'/>
<id>urn:sha1:ce5460f0380a60eb07f70dfed29d1b011636448a</id>
<content type='text'>
(cherry picked from commit 115e99630a317cab62c6f99e0461f6ce2c1edaf3)
</content>
</entry>
<entry>
<title>system_option: T5552: Apply IPv4 and IPv6 options after reapplying sysctls by TuneD (#3863)</title>
<updated>2024-07-25T16:07:28+00:00</updated>
<author>
<name>mergify[bot]</name>
<email>37929162+mergify[bot]@users.noreply.github.com</email>
</author>
<published>2024-07-25T16:07:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=609f4b9c1bb7f3144a997f76e74e86bef0559b23'/>
<id>urn:sha1:609f4b9c1bb7f3144a997f76e74e86bef0559b23</id>
<content type='text'>
(cherry picked from commit 7b82e4005724683c6311fab22358746f2cca4c1b)

Co-authored-by: Nataliia Solomko &lt;natalirs1985@gmail.com&gt;</content>
</entry>
<entry>
<title>T6605: restore configd error formatting to be consistent with CLI (#3868)</title>
<updated>2024-07-25T13:40:57+00:00</updated>
<author>
<name>John Estabrook</name>
<email>jestabro@vyos.io</email>
</author>
<published>2024-07-25T07:15:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=368cb359bfb38b7cde1c84147fd109a533c73c69'/>
<id>urn:sha1:368cb359bfb38b7cde1c84147fd109a533c73c69</id>
<content type='text'>
(cherry picked from commit 645f24908c9b338adc56ecc83f8c44d0b0206550)
</content>
</entry>
<entry>
<title>vrf: T6602: verify supplied VRF name on all interface types (#3870)</title>
<updated>2024-07-25T02:48:39+00:00</updated>
<author>
<name>mergify[bot]</name>
<email>37929162+mergify[bot]@users.noreply.github.com</email>
</author>
<published>2024-07-25T02:48:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=67695c3e7a0d9fdc10ad3e381ad67cb30688e217'/>
<id>urn:sha1:67695c3e7a0d9fdc10ad3e381ad67cb30688e217</id>
<content type='text'>
Only some (e.g. ethernet or wireguard) interfaces validate if the supplied VRF
actually exists. If this is not validated, one can pass an invalid VRF to the
system which generates an OSError exception.

To reproduce

set interfaces vxlan vxlan1 vni 1000
set interfaces vxlan vxlan1 remote 1.2.3.4
set interfaces vxlan vxlan1 vrf smoketest

results in

OSError: [Errno 255] failed to run command: ip link set dev vxlan1 master smoketest_mgmt

This commit adds the missing verify_vrf() call to the missing interface types
and an appropriate smoketest for all interfaces supporting VRF assignment.

(cherry picked from commit dd0ebffa33728e452ac6e11737c2283f0e390359)

Co-authored-by: Christian Breunig &lt;christian@breunig.cc&gt;</content>
</entry>
<entry>
<title>op_mode: T6596: pppoe operation command failed</title>
<updated>2024-07-24T08:51:50+00:00</updated>
<author>
<name>Nataliia Solomko</name>
<email>natalirs1985@gmail.com</email>
</author>
<published>2024-07-24T07:33:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=74e168aff5f6861820d7e0038bfd01e64b532642'/>
<id>urn:sha1:74e168aff5f6861820d7e0038bfd01e64b532642</id>
<content type='text'>
(cherry picked from commit 79407cd5bbec3194a9b6542418229b33eab05121)
</content>
</entry>
<entry>
<title>wireless: T6597: improve hostapd startup and corresponding smoketests</title>
<updated>2024-07-22T19:57:10+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-19T11:54:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=9516ae6ffafa5107ff7e6639c2a2303dc6bc9ae4'/>
<id>urn:sha1:9516ae6ffafa5107ff7e6639c2a2303dc6bc9ae4</id>
<content type='text'>
This was found during smoketesting as thoase started to repeadingly fail in the last weeks

  File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address
      self.assertTrue(process_named_running('hostapd'))
  AssertionError: None is not true

Digging into this revealed that this is NOT related to the smoketest coding but
to hostapd/systemd instead. With a configured WIFI interface and calling:
"sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short
period caused systemd to report:
"Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully."

According to the internal systemd logic used in our version this is explained by:

  /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not
   * undo what has already been enqueued. */
  if (unit_stop_pending(UNIT(s)))
          allow_restart = false;

  if (s-&gt;result == SERVICE_SUCCESS)
          s-&gt;result = f;

  if (s-&gt;result == SERVICE_SUCCESS) {
          unit_log_success(UNIT(s));
          end_state = SERVICE_DEAD;`

Where unit_log_success() generates the log message in question.

Improve the restart login in the wireless interface script and an upgrade to
hostapd solved the issue.

(cherry picked from commit a67f49d99eda00998c425f9a663e138dbd0f7755)
</content>
</entry>
<entry>
<title>wireless: T6320: add 802.11ax at 6GHz</title>
<updated>2024-07-22T19:54:55+00:00</updated>
<author>
<name>Alain Lamar</name>
<email>alain_lamar@yahoo.de</email>
</author>
<published>2024-06-27T18:38:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=e1401753b58906848c81d5c1d1d778be7cc61fb3'/>
<id>urn:sha1:e1401753b58906848c81d5c1d1d778be7cc61fb3</id>
<content type='text'>
Authored-By: Alain Lamar &lt;alain_lamar@yahoo.de&gt;
(cherry picked from commit d5e988ba2d0fa0189feff22374c9b46eb49e2e79)
</content>
</entry>
<entry>
<title>openvpn: T3834: verify() is not allowed to change anything on the system</title>
<updated>2024-07-22T17:20:11+00:00</updated>
<author>
<name>Christian Breunig</name>
<email>christian@breunig.cc</email>
</author>
<published>2024-07-22T14:39:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=334c96afdb906ee08eee66d072c57fcaeb198b02'/>
<id>urn:sha1:334c96afdb906ee08eee66d072c57fcaeb198b02</id>
<content type='text'>
Commit e3c71af1466 ("remove secrets file if the tunnel is deleted and fix
opmode commands") added a code path into verify() which removed files on the
system if TOTP was not defined.

This commit moves the code path to the appropriate generate() function.

(cherry picked from commit 40c835992db9217f48e54dbbf15a7fbf1dcba482)
</content>
</entry>
<entry>
<title>T6599: ipsec: fix incorect default behavior for dead-peer-detection</title>
<updated>2024-07-22T10:28:04+00:00</updated>
<author>
<name>Lucas Christian</name>
<email>lucas@lucasec.com</email>
</author>
<published>2024-07-22T05:46:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos-1x.git/commit/?id=99bce9f6291ef53ecb9507f9b6d61ec28be7be17'/>
<id>urn:sha1:99bce9f6291ef53ecb9507f9b6d61ec28be7be17</id>
<content type='text'>
(cherry picked from commit 23a3419d512139650cfe3dc76759b370b0c0c3d6)
</content>
</entry>
</feed>
