summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2022-07-04 20:40:01 +0200
committerChristian Poessinger <christian@poessinger.com>2022-07-04 20:40:08 +0200
commit171b224c1cf1303a608725ec74b545902daa243e (patch)
tree18b1ca349a9c432d0bc75fcb45209e6f7062932e
parent9483b28a8cf811b9ac03c0bb86083deec8a218ad (diff)
downloadvyos-1x-171b224c1cf1303a608725ec74b545902daa243e.tar.gz
vyos-1x-171b224c1cf1303a608725ec74b545902daa243e.zip
ntp: T4456: call verify_vrf() before individual interface validation
It makes no sense to test against a VRF that might not exist at all.
-rwxr-xr-xsrc/conf_mode/ntp.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/conf_mode/ntp.py b/src/conf_mode/ntp.py
index 7be150ed2..5490a794d 100755
--- a/src/conf_mode/ntp.py
+++ b/src/conf_mode/ntp.py
@@ -50,6 +50,8 @@ def verify(ntp):
if 'allow_clients' in ntp and 'server' not in ntp:
raise ConfigError('NTP server not configured')
+ verify_vrf(ntp)
+
if 'interface' in ntp:
# If ntpd should listen on a given interface, ensure it exists
for interface in ntp['interface']:
@@ -63,7 +65,6 @@ def verify(ntp):
raise ConfigError(f'NTP runs in VRF "{vrf_name}" - "{interface}" '\
f'does not belong to this VRF!')
- verify_vrf(ntp)
return None
def generate(ntp):