diff options
| author | Viacheslav Hletenko <v.gletenko@vyos.io> | 2023-05-09 11:38:12 +0000 |
|---|---|---|
| committer | Viacheslav Hletenko <v.gletenko@vyos.io> | 2023-05-09 12:02:02 +0000 |
| commit | ac0fedb7ac243947451e7263047a0f9e568c643a (patch) | |
| tree | 040255ca61e096403f322b2f362e7ac8f8ff9d32 | |
| parent | 7c23983ba121a23e19ec3bf1d35489b818c25e85 (diff) | |
| download | vyos-1x-ac0fedb7ac243947451e7263047a0f9e568c643a.tar.gz vyos-1x-ac0fedb7ac243947451e7263047a0f9e568c643a.zip | |
T5214: Fix warning if a named pool is defined for PPPoE-server
| -rwxr-xr-x | src/conf_mode/service_pppoe-server.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/conf_mode/service_pppoe-server.py b/src/conf_mode/service_pppoe-server.py index 600ba4e92..adeefaa37 100755 --- a/src/conf_mode/service_pppoe-server.py +++ b/src/conf_mode/service_pppoe-server.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 # -# Copyright (C) 2018-2022 VyOS maintainers and contributors +# Copyright (C) 2018-2023 VyOS maintainers and contributors # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License version 2 or later as @@ -71,8 +71,9 @@ def verify(pppoe): # local ippool and gateway settings config checks if not (dict_search('client_ip_pool.subnet', pppoe) or + (dict_search('client_ip_pool.name', pppoe) or (dict_search('client_ip_pool.start', pppoe) and - dict_search('client_ip_pool.stop', pppoe))): + dict_search('client_ip_pool.stop', pppoe)))): print('Warning: No PPPoE client pool defined') if dict_search('authentication.radius.dynamic_author.server', pppoe): |